Skip to content

Conversation

walburgf
Copy link
Contributor

um auch die Ströme und Spannungen der einzelnen Phasen am Meter des Goodwe-Hybrid template zu sehen, wurden diese per Modbus ausgelesen

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Verify the indentation of the new currents and voltages sections to ensure they align correctly within the existing YAML render block.
  • Factor out the repeated source: modbus include and register definitions (e.g. by using a loop or YAML anchor) to reduce duplication for the six phase entries.
  • Add consistent metadata (such as friendly_name or unit_of_measurement) to each new sensor to align with the existing template conventions.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Verify the indentation of the new `currents` and `voltages` sections to ensure they align correctly within the existing YAML render block.
- Factor out the repeated `source: modbus` include and register definitions (e.g. by using a loop or YAML anchor) to reduce duplication for the six phase entries.
- Add consistent metadata (such as `friendly_name` or `unit_of_measurement`) to each new sensor to align with the existing template conventions.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig andig added the devices Specific device support label Sep 13, 2025
@andig
Copy link
Member

andig commented Sep 14, 2025

Voltages are not used, please remove.

@andig andig merged commit 282e3d8 into evcc-io:master Sep 14, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
devices Specific device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants