chore(cli): consume direct geth blocktest fail fix #1502
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
added
type:chore
marioevz
approved these changes
Apr 28, 2025
Member
marioevz
left a comment
marioevz
left a comment
There was a problem hiding this comment.
LGTM, thanks for rectifying this.
pacrob
pushed a commit
to pacrob/execution-spec-tests
that referenced
this pull request
May 5, 2025
* chore(cli): consume direct geth blocktest fail fix. * chore(docs): add changelog.
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
* chore(cli): consume direct geth blocktest fail fix. * chore(docs): add changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
The refactor from the issue below resulted in missing a check for the test failures when running
consume directfor geth using blockchain test fixtures. This PR adds a fix such that fails are reported correctly and don't simply pass.🔗 Related Issues
#935
ethereum/go-ethereum#30854
✅ Checklist