Skip to content

feat(fw): add max_stack_increase to EOF Section.Code #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
marioevz merged 1 commit into from
Apr 14, 2025
Merged

feat(fw): add max_stack_increase to EOF Section.Code #1446

marioevz merged 1 commit into from
Apr 14, 2025

Conversation

@chfast
Copy link
Member

@chfast chfast commented Apr 14, 2025 •
edited
Loading

🗒️ Description

The max_stack_increase is complementary but preferred to max_stack_height. Both cannot be set at the same time.

🔗 Related Issues

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: A PR with removal of converted JSON/YML tests from ethereum/tests have been opened.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

@chfast chfast added scope:tests Scope: Changes EL client test cases in `./tests` type:feat type: Feature fork:osaka Osaka hardfork scope:fw Scope: Framework (evm|tools|forks|pytest) and removed scope:tests Scope: Changes EL client test cases in `./tests` labels Apr 14, 2025
@chfast chfast requested review from gumb0, marioevz and pdobacz April 14, 2025 12:34
@chfast
feat(fw): add max_stack_increase to EOF Section.Code
4b025ab 
The `max_stack_increase` is complementary but preferred to
`max_stack_height`. Both cannot be set at the same time.
@chfast chfast force-pushed the eof/max_stack_increase branch from 0e951ea to 4b025ab Compare April 14, 2025 12:49
marioevz
marioevz approved these changes Apr 14, 2025
View reviewed changes
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit 91687b7 into ethereum:main Apr 14, 2025
11 checks passed
@marioevz marioevz deleted the eof/max_stack_increase branch April 14, 2025 17:45
@spencer-tb spencer-tb added feature:eof and removed fork:osaka Osaka hardfork labels Apr 29, 2025
pacrob pushed a commit to pacrob/execution-spec-tests that referenced this pull request May 5, 2025
@chfast @pacrob
feat(fw): add max_stack_increase to EOF Section.Code (ethereum#1446)
db64327 
The `max_stack_increase` is complementary but preferred to
`max_stack_height`. Both cannot be set at the same time.
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
@chfast @felix314159
feat(fw): add max_stack_increase to EOF Section.Code (ethereum#1446)
9edaf6c 
The `max_stack_increase` is complementary but preferred to
`max_stack_height`. Both cannot be set at the same time.
kclowes pushed a commit to kclowes/execution-spec-tests that referenced this pull request Oct 20, 2025
@chfast
feat(fw): add max_stack_increase to EOF Section.Code (ethereum#1446)
6340973 
The `max_stack_increase` is complementary but preferred to
`max_stack_height`. Both cannot be set at the same time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marioevz marioevz marioevz approved these changes

@gumb0 gumb0 Awaiting requested review from gumb0

@pdobacz pdobacz Awaiting requested review from pdobacz

Assignees

No one assigned

Labels

feature:eof scope:fw Scope: Framework (evm|tools|forks|pytest) type:feat type: Feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chfast @marioevz @spencer-tb