fix(consume): fix fixture downloads for non-release urls and numerical release specs #1437
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
added
type:bug
8 tasks
danceratopz
commented
Apr 10, 2025
danceratopz
commented
Apr 10, 2025
spencer-tb
approved these changes
Apr 11, 2025
Collaborator
spencer-tb
left a comment
spencer-tb
left a comment
There was a problem hiding this comment.
All LGTM from my side! Thanks :)
17 tasks
pacrob
pushed a commit
to pacrob/execution-spec-tests
that referenced
this pull request
May 5, 2025
…l release specs (ethereum#1437) * fix(consume): fix downloading non-release url tarballs * fix(consume): fix downloading via release spec with numerical version * docs: update changelog * fix typo
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
…l release specs (ethereum#1437) * fix(consume): fix downloading non-release url tarballs * fix(consume): fix downloading via release spec with numerical version * docs: update changelog * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
consume--inputflag with non-release URLs:consume--inputflag with "regular" numerical release specs<tag_name>@v1.2.3, (normal release specs, i.e.,{stable,develop}@latestand pre-release specs, e.g.,[email protected]were working):🔗 Related Issues
Suggested alternative to
✅ Checklist