feat(tests): Additional EIP-2935 coverage #1379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spencer-tb
changed the title
33 tasks
11 tasks
reedsa
force-pushed
the
eip2935-checklist-coverage
branch
2 times, most recently
from
353a108 to
f52c5bc
Compare
reedsa
force-pushed
the
eip2935-checklist-coverage
branch
from
f52c5bc to
cf3279e
Compare
reedsa
added
the
type:test
|
I was tinkering a bit with DELEGATECALL and CALLCODE to match the blockhash returned from the contract. Ended up just verifying that the call is successful. Other tests verify the blockhash when using CALL. If verifying the blockhash when using DELEGATECALL or CALLCODE is critical for this change, we can find a way to do so for these call types. The issue was that the returned Op.BLOCKHASH in storage cannot be cross referenced with the return value of the history contract at the separate address. Maybe I'm missing something that would make this possible. |
marioevz
reviewed
Apr 4, 2025
tests/prague/eip2935_historical_block_hashes_from_state/test_block_hashes.py
Show resolved
Hide resolved
Update CHANGELOG.md
reedsa
force-pushed
the
eip2935-checklist-coverage
branch
from
69e8cbf to
56fa12e
Compare
marioevz
approved these changes
Apr 4, 2025
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
Update CHANGELOG.md
sonhv0212
pushed a commit
to ronin-chain/execution-spec-tests
that referenced
this pull request
May 19, 2025
Update CHANGELOG.md
sonhv0212
pushed a commit
to ronin-chain/execution-spec-tests
that referenced
this pull request
May 20, 2025
Update CHANGELOG.md
sonhv0212
added a commit
to ronin-chain/execution-spec-tests
that referenced
this pull request
May 21, 2025
* feat(tests): EIP-2537: add bls12 audit test cases (ethereum#1275) * fix(test): remove test violating EIP-7523 (ethereum#1257) * fix(test): remove test violating EIP-7523 * Simplify the test by removing parameterization * chore(tests): update bls12 test vectors (ethereum#1289) * new(tests): add state test with empty 7702 authorization list (ethereum#1224) * new(tests): add state test with empty 7702 authorization list * fix(clis): Add exception to EELS --------- Co-authored-by: Mario Vega <[email protected]> * new(tests): EIP-7702: Sender not EOA test * Add self-sponsored variant * apply comments * fix(test): improve EIP-7702 test for type 4 transaction with empty to (ethereum#1337) * fix(tests): EIP-7702 verification/merge issue (ethereum#1358) * new(tests): EIP-7702: More RLP tests (ethereum#1347) * refactor(types): remove nonce-as-list from auth list * new(tests): EIP-7702: Tx serialization tests * refactor(tests): Use RLP encoding changes * Change log * new(tests): EIP-7702: more rlp tests * 🧹 chore(EIP-7623): Remove duplicate fixture (ethereum#1381) Co-authored-by: raxhvl <[email protected]> * feat(tests): Additional EIP-2935 coverage (ethereum#1379) Update CHANGELOG.md * new(tests): EIP-7702: Delegation Designation as Initcode, max-fee-per-gas tests (ethereum#1372) * new(tests): EIP-7702: Delegation designation as initcode * new(tests): EIP-7702: Invalid max_fee_per_gas/max_priority_fee_per_gas * docs: changelog * refactor(tests): Combine similar cases into one Co-Authored-By: spencer <[email protected]> --------- Co-authored-by: spencer <[email protected]> * fix(execute,tests): EIP-7702: send tx of eoa after setcode tx is mined (ethereum#1411) * fix(tests): EIP-7702: send transaction of an EOA after setcode tx is mined * refactor(execute): send batch of txs by block * fix(tests): Parametrize instead of change * refactor(execution): Change error check to per-block basis --------- Co-authored-by: Mario Vega <[email protected]> * feat(tests): update 7702 precompile test cases (ethereum#1431) - Add a test case that calls the delegated precompile acct directly from the same transaction as the auth. Supply enough gas only to cover the intrinsic cost of the call, with no extra gas for any precompile code execution. - Update the test case for all call opcodes to use all of the call opcodes. * feat(tests): eip7623 - parametrize `test_transaction_validity_type_*` with a tx to an eoa (ethereum#1422) * feat(tests): EIP-2537: extra BLS12-381 coverage (ethereum#1350) * feat(tests): bls point generator and extra coverage. * chore(tests): remove bls msm duplicates. * chore: fix tox issues. * feat(tests): Add more msm invalid tests --------- Co-authored-by: Mario Vega <[email protected]> * new(tests): EIP-7702 - ensure DELEGATECALLing a 7702 target works (ethereum#1485) Co-authored-by: Mario Vega <[email protected]> * feat(tests): add bls map to curve on identity cases (ethereum#1505) * fix(tests): EIP-7702: use penultimate block number instead of fixing block 0 (ethereum#1390) * fix(tests): EIP-7702: use penultimate block number instead of fixing block 0 * fix(tests): EIP-7702: use contract code to get blocknumber instead of rpc * Update uv.lock * Update uv.lock * Update uv.lock * Update uv.lock * Update pyproject.toml * refactor(base_types,types,tests): Create RLP Serialization Classes (ethereum#1359) * fix(types): tests: Add serialization unit tests * fix(types): tests: Fix unit tests * feat(base_types): Implement serialization RLP types * feat(base_types,types,fixtures): Apply serialization RLP types * fix(types): Auth tuple defaults * fix(fixtures,rpc,specs,types,tests): Transaction.rlp is a function * fix(base_types,types,rpc): fixes * refactor(base_types,types): Network wrapped transaction * fix(tests): Network wrapped transactions * fix(types): Fix NetworkWrappedTransaction rlp prefix * docs: Changelog * Apply suggestions from code review Co-authored-by: spencer <[email protected]> * Add network wrapper explanation * fix: tox * Update docs/CHANGELOG.md Co-authored-by: spencer <[email protected]> * Add comment --------- Co-Authored-By: spencer <[email protected]> * fix(tests): EIP-2537: mark slow * fix(tests): EIP-7623: remove blob in blob tx * fix(dependency): update prague execution specs * new(dependency): add joblib --------- Co-authored-by: spencer <[email protected]> Co-authored-by: Andrei Maiboroda <[email protected]> Co-authored-by: Paweł Bylica <[email protected]> Co-authored-by: Mario Vega <[email protected]> Co-authored-by: Dimitry Kh <[email protected]> Co-authored-by: raxhvl <[email protected]> Co-authored-by: raxhvl <[email protected]> Co-authored-by: Stuart Reed <[email protected]> Co-authored-by: felipe <[email protected]> Co-authored-by: danceratopz <[email protected]> Co-authored-by: pdobacz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Additional coverage for checklist items in https://github.com/ethereum/execution-spec-tests/blob/eip-checklist/docs/checklist_templates/eip_testing_checklist_template.md#-new-system-contract
🔗 Related Issues
✅ Checklist
mkdocs servelocally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.