Skip to content

new(tests): EOF validation RETF stack overflow #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

hugo-dc
Copy link
Member

@hugo-dc hugo-dc commented Mar 23, 2025

πŸ—’οΈ Description

πŸ”— Related Issues

βœ… Checklist

@hugo-dc hugo-dc requested a review from chfast March 23, 2025 06:56
@hugo-dc hugo-dc marked this pull request as draft March 23, 2025 13:35
@hugo-dc hugo-dc marked this pull request as ready for review March 23, 2025 16:59
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just a few comments, and I echo Dimitry's comment that expected_bytecode could be removed, specially when we already have PRs like #1339 where adding more tests that use this field would result in more rework.

@hugo-dc hugo-dc force-pushed the retf_stack_overflow branch from e4e88b2 to 3f30efd Compare March 26, 2025 19:40
@chfast chfast added the scope:tests Scope: Changes EL client test cases in `./tests` label Apr 1, 2025
@hugo-dc hugo-dc force-pushed the retf_stack_overflow branch from 3f30efd to 1f035cb Compare April 4, 2025 05:28
@hugo-dc hugo-dc force-pushed the retf_stack_overflow branch from 1f035cb to 09bbffb Compare April 4, 2025 06:28
@chfast chfast merged commit 2b63584 into ethereum:main Apr 4, 2025
11 checks passed
felix314159 pushed a commit to felix314159/execution-spec-tests that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope:tests Scope: Changes EL client test cases in `./tests`
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants