feat(consume): add support for ethereum/{tests,legacytests} tarball urls #1306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danceratopz
added
type:feat
3 tasks
winsvega
approved these changes
Mar 13, 2025
Detect single directory within archive instead of a hard-coded "fixtures" directory.
danceratopz
force-pushed
the
consume-cache-for-ethereum-tests
branch
from
430e007 to
b7ffcc5
Compare
|
@winsvega this now works: |
spencer-tb
approved these changes
Mar 17, 2025
There was a problem hiding this comment.
LGTM! Runs in hive for me with the following:
./hive --sim "ethereum/eest/consume-rlp" --client go-ethereum --client-file=configs/prague.yaml --client.checktimelimit=60s --sim.parallelism=1 --docker.output --sim.buildarg fixtures=https://github.com/ethereum/tests/releases/download/v17.0/fixtures_blockchain_tests.tgz --sim.buildarg branch=consume-cache-for-ethereum-tests --sim.loglevel=3 --docker.output --docker.nocache go-ethereumLet's get ethereum/tests running in consume-rlp on hiveview :D!
felix314159
pushed a commit
to felix314159/execution-spec-tests
that referenced
this pull request
May 16, 2025
…rls (ethereum#1306) * feat(consume): add support for ethereum/{tests,legacytests} tarball urls * docs: update changelog * fix(consume): don't extract to hard-coded fixtures directory Detect single directory within archive instead of a hard-coded "fixtures" directory. * fix(consume): fix tag matching when fetching releases * docs: add advisory to changelog about cache dir changes * fix(consume): revert incorrect "fix" from 39b0f54
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
Adds tarball release URL download support for ethereum/tests and ethereum/legacytests to
consume, for example:An additional fix that was required to enable this feature with the above tarball: Don't assume that the directory contained within the tarball is hard-coded as "fixtures", now the top-level directory name is automatically detected, this was the offending code:
execution-spec-tests/src/pytest_plugins/consume/consume.py
Line 122 in ab62c8d
and
execution-spec-tests/src/pytest_plugins/consume/consume.py
Line 130 in ab62c8d
🔗 Related Issues
✅ Checklist