Skip to content

Conversation

@okhsunrog
Copy link
Contributor

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • [+ ] I have updated existing examples or added new ones (if applicable).
  • [+ ] I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • I have added necessary changes to user code to the Migration Guide.
  • [+ ] My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

After #2099 we need to explicitly setup heap for esp-wifi crate. The wifi_embassy_ble.rs example was updated, but the wifi_embassy_trouble.rs, which was introduces by another PR in the same day isn't updated yet. This small PR fixes the example so it's consistent with the other esp-wifi examples.

Copy link
Member

@MabezDev MabezDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, good catch, thanks!

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bjoernQ bjoernQ added this pull request to the merge queue Sep 12, 2024
Merged via the queue into esp-rs:main with commit b5152dc Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants