Allow pin drivers as wakeup sources #2095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
rtc
branch
2 times, most recently
from
046eba5 to
71e305f
Compare
bugadani
commented
Sep 5, 2024
|
|
||
| #[doc(hidden)] | ||
| #[macro_export] | ||
| macro_rules! handle_rtcio { |
Contributor
Author
There was a problem hiding this comment.
Next up, how can I delete these... I'm hoping there is a solution that allows me to factor this as a repeat_erased! and a filter_branches! macro, but I haven't tried anything yet.
bugadani
force-pushed
the
rtc
branch
3 times, most recently
from
d0a9b43 to
38abd6e
Compare
bugadani
commented
Sep 5, 2024
| #[cfg(any(xtensa, esp32c2, esp32c3, esp32c6))] | ||
| impl RtcPin for ErasedPin { | ||
| #[cfg(xtensa)] | ||
| #[allow(unused_braces)] // False positive :/ |
Contributor
Author
There was a problem hiding this comment.
bjoernQ
approved these changes
Sep 9, 2024
Contributor
bjoernQ
left a comment
bjoernQ
left a comment
There was a problem hiding this comment.
LGTM - makes things more convenient!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2020