Skip to content

Remove gpio dispatch macro-defining proc macro #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jessebraham merged 6 commits into from
Sep 4, 2024
Merged

Remove gpio dispatch macro-defining proc macro #2069

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9057a37
Keep a single PinType trait
bugadani Sep 3, 2024
06dc14c
Merge impl blocks
bugadani Sep 3, 2024
fe2feb6
Deduplicate usb pad workaround
bugadani Sep 3, 2024
59e1fa4
Deduplicate some bit manipulation
bugadani Sep 3, 2024
abfcd4b
Remove gpio dispatch proc macro
bugadani Sep 3, 2024
479c91a
Inline PinType into GpioProperties
bugadani Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
77 changes: 0 additions & 77 deletions esp-hal-procmacros/src/enum_dispatch.rs
View file
Open in desktop

This file was deleted.

33 changes: 0 additions & 33 deletions esp-hal-procmacros/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,6 @@ use proc_macro::TokenStream;

#[cfg(feature = "embassy")]
mod embassy;
#[cfg(feature = "enum-dispatch")]
mod enum_dispatch;
#[cfg(feature = "interrupt")]
mod interrupt;
#[cfg(any(
Expand Down Expand Up @@ -339,37 +337,6 @@ pub fn handler(args: TokenStream, input: TokenStream) -> TokenStream {
.into()
}

/// Create an enum for erased GPIO pins, using the enum-dispatch pattern
///
/// Only used internally
#[cfg(feature = "enum-dispatch")]
#[proc_macro]
pub fn make_gpio_enum_dispatch_macro(input: TokenStream) -> TokenStream {
use quote::{format_ident, quote};

use self::enum_dispatch::{build_match_arms, MakeGpioEnumDispatchMacro};

let input = syn::parse_macro_input!(input as MakeGpioEnumDispatchMacro);

let macro_name = format_ident!("{}", input.name);
let arms = build_match_arms(input);

quote! {
#[doc(hidden)]
#[macro_export]
macro_rules! #macro_name {
($m:ident, $target:ident, $body:block) => {
match $m {
#(#arms)*
}
}
}

pub(crate) use #macro_name;
}
.into()
}

/// Load code to be run on the LP/ULP core.
///
/// ## Example
Expand Down
Loading