Skip to content

Conversation

@SergioGasquez
Copy link
Member

Thank you for your contribution!

We appreciate the time and effort you've put into this pull request.
To help us review it efficiently, please ensure you've gone through the following checklist:

Submission Checklist 📝

  • I have updated existing examples or added new ones (if applicable).
  • I have used cargo xtask fmt-packages command to ensure that all changed code is formatted correctly.
  • My changes were added to the CHANGELOG.md in the proper section.
  • My changes are in accordance to the esp-rs API guidelines

Extra:

Pull Request Details 📖

Description

  • If running the tests fails, we erase the target flash to avoid subsequent test failures due to a peripheral being in a weird state.
  • Added docs for installing espflash

Testing

Not tested (not sure how I can test it)

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SergioGasquez SergioGasquez force-pushed the feat/hil-erase-flash branch from 59c0917 to de4dde8 Compare July 4, 2024 07:40
Copy link
Contributor

@JurajSadel JurajSadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@JurajSadel JurajSadel enabled auto-merge July 4, 2024 07:45
@JurajSadel JurajSadel added this pull request to the merge queue Jul 4, 2024
Merged via the queue into esp-rs:main with commit 786682c Jul 4, 2024
@SergioGasquez SergioGasquez deleted the feat/hil-erase-flash branch July 4, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants