This repository was archived by the owner on Jan 19, 2019. It is now read-only.
Fix: Set name to type JSXIdentifier and fix selfClosing (fixes #172) #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#172) JSXAttribute name property should be a node with type JSXIdentifier. Selfclosing tags cannot check the parent node since its parent is the outside tag. This is becuase we convert the JSXSelfClosingElement to a JSXOpeningElement and do not change the parent. This commit converts the node and then sets selfClosing instead of depending on the parent node.
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSXAttribute name property should be a node with type JSXIdentifier.
Self closing tags cannot check the parent node since its parent is
the outside tag. This is because we convert the JSXSelfClosingElement to a
JSXOpeningElement and do not change the parent. This commit converts
the node and then sets selfClosing instead of depending on the parent node.