Skip to content

chore: update @eslint/core, add legacy-peer-deps, and use ESLint v10 #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lumirlumir wants to merge 7 commits into
base: main
Choose a base branch
from
Open

chore: update @eslint/core, add legacy-peer-deps, and use ESLint v10 #190

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1ab1bd5
chore: update dependency @eslint/core to v1
lumirlumir Dec 2, 2025
6458723
wip
lumirlumir Dec 2, 2025
ad826d2
wip
lumirlumir Dec 2, 2025
89ae354
wip: remove `errors` in `valid` test case
lumirlumir Dec 2, 2025
d7d3b71
wip: replace `ESLint.Plugin` with `Plugin`
lumirlumir Dec 7, 2025
466cdc6
wip: clarify comment and change version range for `eslint`
lumirlumir Dec 10, 2025
e08f03f
Merge branch 'main' into chore-update-dependency-eslint-core-v1
lumirlumir Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
package-lock = false
legacy-peer-deps = true # TODO: Remove this line after ESLint v10 is released.
4 changes: 2 additions & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,15 +83,15 @@
],
"license": "Apache-2.0",
"dependencies": {
"@eslint/core": "^0.17.0",
"@eslint/core": "^1.0.0",
Copy link
Member

@mdjermanovic mdjermanovic Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a dependency, will this affect end users who are still using ESLint v9?

Copy link
Member

@nzakas nzakas Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The next release will be a major one, so I think it's okay.

"@eslint/plugin-kit": "^0.5.0",
"@humanwhocodes/momoa": "^3.3.10",
"natural-compare": "^1.4.0"
},
"devDependencies": {
"c8": "^10.1.3",
"dedent": "^1.5.3",
"eslint": "^9.36.0",
"eslint": ">=10.0.0-alpha.0 <10.0.0 || ^10.0.1",
"eslint-config-eslint": "^13.0.0",
"eslint-plugin-eslint-plugin": "^6.3.2",
"globals": "^16.5.0",
Expand Down
5 changes: 0 additions & 5 deletions tests/rules/sort-keys.test.js
View file
Open in desktop
Copy link
Member Author

@lumirlumir lumirlumir Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From ESLint v10, errors property in valid test case throws error, so I've removed it.

Ref: https://eslint.org/docs/next/use/migrate-to-10.0.0#stricter-rule-tester

Original file line number Diff line number Diff line change
Expand Up @@ -83,11 +83,6 @@ ruleTester.run("sort-keys", rule, {
`,
language: "json/json5",
options: [],
errors: [
{
messageId: "sortKeys",
},
],
},

// asc
Expand Down
5 changes: 2 additions & 3 deletions tests/types/types.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
import json, { JSONSourceCode } from "@eslint/json";
import type { ESLint } from "eslint";
import type {
JSONSyntaxElement,
JSONRuleDefinition,
Expand All @@ -21,9 +20,9 @@ import type {
StringNode,
LocationRange,
} from "@humanwhocodes/momoa";
import type { SourceLocation, SourceRange } from "@eslint/core";
import type { Plugin, SourceLocation, SourceRange } from "@eslint/core";

json satisfies ESLint.Plugin;
json satisfies Plugin;
json.meta.name satisfies string;
json.meta.version satisfies string;

Expand Down