access logging: support custom tag on ALS #18955

Shikugawa · 2021-11-10T07:51:45Z

Signed-off-by: Shikugawa [email protected]

Commit Message: access logging: support custom tag on ALS
Additional Description: Close #18910. This PR adds custom tag feature that is similar to tracing span's. In this PR, we support this for ALS only.
Risk Level: Low
Testing: Unit
Docs Changes: Required
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Shikugawa <[email protected]>

repokitteh-read-only · 2021-11-10T07:51:48Z

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #18955 was opened by Shikugawa.

see: more, trace.

repokitteh-read-only · 2021-11-10T07:51:52Z

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to (api/envoy/|docs/root/api-docs/).
envoyproxy/api-shepherds assignee is @lizan
CC @envoyproxy/api-watchers: FYI only for changes made to (api/envoy/|docs/root/api-docs/).

🐱

Caused by: #18955 was opened by Shikugawa.

see: more, trace.

Signed-off-by: Shikugawa <[email protected]>

…ustom-tag Signed-off-by: Shikugawa <[email protected]>

Signed-off-by: Shikugawa <[email protected]>

Shikugawa · 2021-11-12T12:11:41Z

/retest

repokitteh-read-only · 2021-11-12T12:11:44Z

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18955 (comment) was created by @Shikugawa.

see: more, trace.

Shikugawa · 2021-11-16T04:53:54Z

/retest

repokitteh-read-only · 2021-11-16T04:53:58Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18955 (comment) was created by @Shikugawa.

see: more, trace.

lizan · 2021-11-16T22:27:19Z

@mathetake first pass?

api/envoy/data/accesslog/v3/accesslog.proto

mathetake · 2021-11-17T00:06:14Z

envoy/tracing/trace_driver.h

@@ -5,6 +5,7 @@
 #include <vector>

 #include "envoy/common/pure.h"
+#include "envoy/data/accesslog/v3/accesslog.pb.h"


so this introduces the dependency on access_logs in tracing/trace_driver? I understand how this ends up here but seems a bit weird to me.

I also considered this dependency seems weird, then submitted refactor PR. #18942 (comment)
But, maintainers referred to me utilizing the current API.

huh I see... Thanks for putting the effort there!

envoy/tracing/trace_driver.h

mathetake · 2021-11-17T00:08:14Z

Made drive-by comments :D

Signed-off-by: Shikugawa <[email protected]>

Shikugawa · 2021-11-22T13:24:09Z

@lizan Could you take a look?

ggreenway · 2021-12-02T22:11:18Z

@lizan ping

wu-sheng · 2021-12-07T07:14:45Z

@lizan Could you help on this?

source/extensions/access_loggers/grpc/BUILD

Signed-off-by: Shikugawa <[email protected]>

Shikugawa · 2021-12-09T02:14:57Z

/retest

repokitteh-read-only · 2021-12-09T02:15:01Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18955 (comment) was created by @Shikugawa.

see: more, trace.

Shikugawa · 2021-12-10T15:03:44Z

@envoyproxy/envoy-maintainers Could anyone help this?

lizan

Can you extract the custom tag refactor to another PR? otherwise looks good to me.

phlax · 2021-12-14T15:34:48Z

/wait

Additional Description: This is part of #18955. Risk Level: Low Testing: CI Docs Changes: Release Notes: Platform Specific Features: Signed-off-by: Shikugawa <[email protected]>

Signed-off-by: Shikugawa <[email protected]>

lizan

/retest

repokitteh-read-only · 2022-01-03T18:52:46Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18955 (review) was submitted by @lizan.

see: more, trace.

lizan · 2022-01-04T19:37:36Z

/assign-from @envoyproxy/envoy-maintainers

repokitteh-read-only · 2022-01-04T19:37:40Z

@envoyproxy/envoy-maintainers assignee is @snowp

🐱

Caused by: a #18955 (comment) was created by @lizan.

see: more, trace.

Shikugawa · 2022-01-07T05:24:30Z

@snowp friendly ping

snowp

Thanks!

wu-sheng · 2022-01-08T02:32:23Z

Great to see this gets merged.

Related envoyproxy/envoy#18955

…19288) Additional Description: This is part of envoyproxy#18955. Risk Level: Low Testing: CI Docs Changes: Release Notes: Platform Specific Features: Signed-off-by: Shikugawa <[email protected]> Signed-off-by: Josh Perry <[email protected]>

Signed-off-by: Shikugawa <[email protected]> Signed-off-by: Josh Perry <[email protected]>

access logging: support custom tag on ALS

f456986

Signed-off-by: Shikugawa <[email protected]>

repokitteh-read-only bot added the api label Nov 10, 2021

repokitteh-read-only bot assigned lizan Nov 10, 2021

add test

0e373eb

Signed-off-by: Shikugawa <[email protected]>

Shikugawa marked this pull request as ready for review November 10, 2021 10:31

add release notes

4dbdc52

Signed-off-by: Shikugawa <[email protected]>

Shikugawa requested review from mathetake and lizan November 10, 2021 10:36

Shikugawa mentioned this pull request Nov 10, 2021

api: move tracing/custom_tag to custom_tag/custom_tag #18942

Closed

Shikugawa added 3 commits November 12, 2021 14:59

fix

e8a4ca9

Signed-off-by: Shikugawa <[email protected]>

Merge branch 'main' of https://github.com/envoyproxy/envoy into log-c…

31d5391

…ustom-tag Signed-off-by: Shikugawa <[email protected]>

fix

6b4454d

Signed-off-by: Shikugawa <[email protected]>

mathetake reviewed Nov 17, 2021

View reviewed changes

api/envoy/data/accesslog/v3/accesslog.proto Outdated Show resolved Hide resolved

mathetake reviewed Nov 17, 2021

View reviewed changes

envoy/tracing/trace_driver.h Outdated Show resolved Hide resolved

fix

ee0e191

Signed-off-by: Shikugawa <[email protected]>

lizan reviewed Dec 7, 2021

View reviewed changes

source/extensions/access_loggers/grpc/BUILD Outdated Show resolved Hide resolved

fix

df2b0ab

Signed-off-by: Shikugawa <[email protected]>

Shikugawa requested a review from alyssawilk as a code owner December 8, 2021 08:58

Shikugawa added 2 commits December 8, 2021 22:19

fix

f2c5a0d

Signed-off-by: Shikugawa <[email protected]>

fix

3373d28

Signed-off-by: Shikugawa <[email protected]>

lizan reviewed Dec 10, 2021

View reviewed changes

repokitteh-read-only bot added the waiting label Dec 14, 2021

Shikugawa mentioned this pull request Dec 15, 2021

tracing: separate custom tag interface from trace driver #19288

Merged

fix

f4c3b02

Signed-off-by: Shikugawa <[email protected]>

repokitteh-read-only bot removed the waiting label Dec 31, 2021

lizan reviewed Jan 3, 2022

View reviewed changes

lizan removed their assignment Jan 4, 2022

lizan approved these changes Jan 4, 2022

View reviewed changes

repokitteh-read-only bot removed the api label Jan 4, 2022

repokitteh-read-only bot assigned snowp Jan 4, 2022

snowp approved these changes Jan 7, 2022

View reviewed changes

snowp merged commit b136310 into envoyproxy:main Jan 7, 2022

kezhenxu94 added a commit to apache/skywalking that referenced this pull request Jan 17, 2022

Sync proto buffers files from upstream Envoy

b09d4de

Related envoyproxy/envoy#18955

kezhenxu94 added a commit to apache/skywalking that referenced this pull request Jan 17, 2022

Sync proto buffers files from upstream Envoy

e1a743f

Related envoyproxy/envoy#18955

kezhenxu94 mentioned this pull request Jan 17, 2022

Sync proto buffers files from upstream Envoy apache/skywalking#8434

Merged

2 tasks

kezhenxu94 added a commit to apache/skywalking that referenced this pull request Jan 17, 2022

Sync proto buffers files from upstream Envoy (#8434)

810d840

Related envoyproxy/envoy#18955

joshperry pushed a commit to joshperry/envoy that referenced this pull request Feb 13, 2022

access logging: support custom tag on ALS (envoyproxy#18955)

8740e01

Signed-off-by: Shikugawa <[email protected]> Signed-off-by: Josh Perry <[email protected]>

access logging: support custom tag on ALS #18955

access logging: support custom tag on ALS #18955

Uh oh!

Conversation

Shikugawa commented Nov 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Nov 10, 2021

Uh oh!

repokitteh-read-only bot commented Nov 10, 2021

Uh oh!

Shikugawa commented Nov 12, 2021

Uh oh!

repokitteh-read-only bot commented Nov 12, 2021

Uh oh!

Shikugawa commented Nov 16, 2021

Uh oh!

repokitteh-read-only bot commented Nov 16, 2021

Uh oh!

lizan commented Nov 16, 2021

Uh oh!

Uh oh!

mathetake Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

Shikugawa Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

mathetake Nov 17, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mathetake commented Nov 17, 2021

Uh oh!

Shikugawa commented Nov 22, 2021

Uh oh!

ggreenway commented Dec 2, 2021

Uh oh!

wu-sheng commented Dec 7, 2021

Uh oh!

Uh oh!

Shikugawa commented Dec 9, 2021

Uh oh!

repokitteh-read-only bot commented Dec 9, 2021

Uh oh!

Shikugawa commented Dec 10, 2021

Uh oh!

lizan left a comment

Choose a reason for hiding this comment

Uh oh!

phlax commented Dec 14, 2021

Uh oh!

lizan left a comment

Choose a reason for hiding this comment

Uh oh!

repokitteh-read-only bot commented Jan 3, 2022

Uh oh!

lizan commented Jan 4, 2022

Uh oh!

repokitteh-read-only bot commented Jan 4, 2022

Uh oh!

Shikugawa commented Jan 7, 2022

Uh oh!

snowp left a comment

Choose a reason for hiding this comment

Uh oh!

wu-sheng commented Jan 8, 2022

Uh oh!

Uh oh!

Shikugawa commented Nov 10, 2021 •

edited

Loading