Skip to content

ENSIP-24 Resolver Profile for Arbitrary Data Resolution #503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
clowestab wants to merge 5 commits into
base: staging
Choose a base branch
from
Open

ENSIP-24 Resolver Profile for Arbitrary Data Resolution #503

clowestab wants to merge 5 commits into from

Conversation

@clowestab
Copy link

@clowestab clowestab commented Nov 25, 2025

  • Added ENSIP-24 Interfaces x2
  • Added basic mixin
  • Added basic test coverage
  • Updated README

@adraffy adraffy self-requested a review December 1, 2025 09:21
adraffy
adraffy requested changes Dec 3, 2025
View reviewed changes
Copy link
Member

@adraffy adraffy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a separate mixin for the iterable ISupportedDataKeys.

PublicResolver should only implement the non-iterable mixin (just IDataResolver).

Both mixins should support versioning.

Once merged, I'll add support in ENSv2 DedicatedResolver.

@clowestab
Copy link
Author

clowestab commented Dec 5, 2025

Separated mixins as requested. Added an _afterSetData() hook to DataResolver to connect the two.
Added versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adraffy adraffy adraffy requested changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@clowestab @adraffy