Skip to content

Conversation

@adraffy
Copy link
Member

@adraffy adraffy commented Mar 9, 2025



@adraffy adraffy marked this pull request as draft March 12, 2025 08:38
@adraffy adraffy changed the title UniversalResolver (WIP) UniversalResolver2 Mar 12, 2025
@adraffy adraffy requested a review from TateB March 12, 2025 09:05
@adraffy
Copy link
Member Author

adraffy commented Mar 12, 2025

I think a possible simplification to IForwardResolver would be to remove lookupName() and just use resolve() w/o any calls:

Lookup memory lookup = lookupName(name);
// is the same as
(Lookup memory lookup, ) = resolve(name, [], []);

Additionally, we could expose (sub)registries and remove IForwardResolution.registry() using the following changes:

struct Lookup {
    // same stuff
    address registry; // ** new value **
}

// v1
(Lookup memory lookup, ) = resolve("raffy.eth", [], [])
// lookup.registry is always 0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e

// v2
(Lookup memory lookup, ) = resolve("raffy.eth", [], [])
// lookup.registry is subregistry

This would simplify IForwardResolver to a single function:

interface IForwardResolution {
    function resolve(
        bytes memory name,
        bytes[] memory calls,
        string[] memory batchedGateways
    ) external view returns (Lookup memory lookup, Response[] memory res);
}

@adraffy adraffy changed the title UniversalResolver2 UniversalResolver2 + forge Rewrites Mar 15, 2025
@adraffy adraffy changed the title UniversalResolver2 + forge Rewrites new UniversalResolver + forge Rewrites Mar 16, 2025
@adraffy adraffy closed this Mar 17, 2025
@adraffy adraffy deleted the feature/bet-193-develop-a-standardized-universalresolver-compatible-with-v1 branch May 16, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant