-
Notifications
You must be signed in to change notification settings - Fork 496
new UniversalResolver + forge Rewrites #416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
adraffy
wants to merge
17
commits into
staging
from
feature/bet-193-develop-a-standardized-universalresolver-compatible-with-v1
Closed
new UniversalResolver + forge Rewrites #416
adraffy
wants to merge
17
commits into
staging
from
feature/bet-193-develop-a-standardized-universalresolver-compatible-with-v1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UR1 rename to UR2
Member
Author
|
I think a possible simplification to IForwardResolver would be to remove Lookup memory lookup = lookupName(name);
// is the same as
(Lookup memory lookup, ) = resolve(name, [], []);Additionally, we could expose (sub)registries and remove struct Lookup {
// same stuff
address registry; // ** new value **
}
// v1
(Lookup memory lookup, ) = resolve("raffy.eth", [], [])
// lookup.registry is always 0x00000000000C2E074eC69A0dFb2997BA6C7d2e1e
// v2
(Lookup memory lookup, ) = resolve("raffy.eth", [], [])
// lookup.registry is subregistryThis would simplify interface IForwardResolution {
function resolve(
bytes memory name,
bytes[] memory calls,
string[] memory batchedGateways
) external view returns (Lookup memory lookup, Response[] memory res);
} |
…nge Lookup.extended to bits, start UR2 hardhat tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
setForwardResolution()(eg. v1 → v2)setBatchedGateways()resolve(multicall)is understood by the resolver, the batched gateway is bypassedbun run test:remote)NameEncoderseems wrongencryptLongNamestoencode()readLabel()/namehash()0.reverse(not"".reverseor00.reverse) and1.reverse(not01.reverse)resolve(multicall)compare()