Skip to content

Add check in makeCommitment for resolver != address(0) when reverseResolver = True (from lcfr-eth) #329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeonmanRolls wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

Add check in makeCommitment for resolver != address(0) when reverseResolver = True (from lcfr-eth) #329

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions contracts/ethregistrar/ETHRegistrarController.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ error CommitmentTooOld(bytes32 commitment);
error NameNotAvailable(string name);
error DurationTooShort(uint256 duration);
error ResolverRequiredWhenDataSupplied();
error ResolverRequiredWhenReverseRecord();
error UnexpiredCommitmentExists(bytes32 commitment);
error InsufficientValue();
error Unauthorised(bytes32 node);
Expand Down Expand Up @@ -120,6 +121,9 @@ contract ETHRegistrarController is
uint16 ownerControlledFuses
) public pure override returns (bytes32) {
bytes32 label = keccak256(bytes(name));
if (resolver == address(0) && reverseRecord == true) {
revert ResolverRequiredWhenReverseRecord();
}
if (data.length > 0 && resolver == address(0)) {
revert ResolverRequiredWhenDataSupplied();
}
Expand Down