-
-
Notifications
You must be signed in to change notification settings - Fork 36
Feature: update romm mapping according to version 4.1.6 #1847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Good so far! Missing the following changes:
|
good catch ! |
|
Apologies for the delay @DrummyFloyd, let me review this and get it merged! Thank you for the submission! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1847 +/- ##
==========================================
+ Coverage 90.31% 90.34% +0.03%
==========================================
Files 155 155
Lines 9528 9528
Branches 2260 2361 +101
==========================================
+ Hits 8605 8608 +3
+ Misses 921 880 -41
- Partials 2 40 +38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Don't need to apologize :) Thank you for the review/merge :) And thank you for this amazing tool ! |
hi,
like the title says this is a minor update of
rommmanager based on the latest doc herenb: i linked this pr to an issue on romm project too to advertise the romm maintainer