Skip to content

Conversation

@DrummyFloyd
Copy link

@DrummyFloyd DrummyFloyd commented Aug 27, 2025

hi,
like the title says this is a minor update of romm manager based on the latest doc here

nb: i linked this pr to an issue on romm project too to advertise the romm maintainer

@github-actions github-actions bot changed the title feat(romm): update mapping according to version 4.1.6 Feature: update mapping according to version 4.1.6 Aug 27, 2025
@gantoine
Copy link

Good so far! Missing the following changes:

  • turbografx16--1 -> tg16
  • turbografxa-cd -> turbografx-cd
  • watara-slash-quickshot-supervision -> supervision

@DrummyFloyd
Copy link
Author

Good so far! Missing the following changes:

* `turbografx16--1` -> `tg16`

* `turbografxa-cd` -> `turbografx-cd`

* `watara-slash-quickshot-supervision` -> `supervision`

good catch !
pushed new changes

@DrummyFloyd DrummyFloyd changed the title Feature: update mapping according to version 4.1.6 feat(romm): update mapping according to version 4.1.6 Aug 29, 2025
@github-actions github-actions bot changed the title feat(romm): update mapping according to version 4.1.6 Feature: update mapping according to version 4.1.6 Aug 29, 2025
@DrummyFloyd DrummyFloyd changed the title Feature: update mapping according to version 4.1.6 Feature: update romm mapping according to version 4.1.6 Sep 5, 2025
@emmercm
Copy link
Owner

emmercm commented Sep 27, 2025

Apologies for the delay @DrummyFloyd, let me review this and get it merged! Thank you for the submission!

@codecov
Copy link

codecov bot commented Sep 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.34%. Comparing base (d2461a7) to head (63d4b05).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1847      +/-   ##
==========================================
+ Coverage   90.31%   90.34%   +0.03%     
==========================================
  Files         155      155              
  Lines        9528     9528              
  Branches     2260     2361     +101     
==========================================
+ Hits         8605     8608       +3     
+ Misses        921      880      -41     
- Partials        2       40      +38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DrummyFloyd
Copy link
Author

DrummyFloyd commented Sep 27, 2025

Apologies for the delay @DrummyFloyd, let me review this and get it merged! Thank you for the submission!

Don't need to apologize :)

Thank you for the review/merge :)

And thank you for this amazing tool !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants