Additional test cases for probing MTU/transact size for various dialects #62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WiP TODO: relocate the write/read tests
move TreeConnectWithDialect into pike.test package init
allow assert_error to take an arbitrary number of ntstatus to check against
add dialect gates for dialect specific tests use new assert_error to assert on multiple status given differing windows behavior fix pep8
isi-mfurer
changed the title
corenec
reviewed
Apr 11, 2019
| flags=0, | ||
| file_index=0, | ||
| file_name='{0}*'.format(self.filename_prefix), | ||
| output_buffer_length=self.payload_size) |
There was a problem hiding this comment.
Shouldn't we be using max_trans_size here rather than payload_size? (Isn't the goal here to test that we can do a full max_trans_size transfer?)
Contributor
Author
There was a problem hiding this comment.
well windows 10 / windows server 2016 return 8mb for max_trans_size, but will still fail the request if the client asks for a buffer larger than 64k, so i'm not really sure why those servers are returning such a large max_trans_size. any ideas would be welcome
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Log of running the new tests against onefs 8.1.1, onefs staging 008, windows 7, and windows 2016
https://gist.github.com/isi-mfurer/5f6d30c25a822060e48b04e0e1a1e197