-
-
Notifications
You must be signed in to change notification settings - Fork 38
Update README.md #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #683
Conversation
Added gettext dependency
ryonakano
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! Would you sort the list alphabetically? Otherwise LGTM.
Sorted dependencies alphabetically and added some clarity around how to use them + build the application. This was helpful for me when starting out
LuminousHustler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a noob myself, I found these small updates/clarifications helpful when starting out
| Run `meson` to configure the build environment and then `ninja` to build | ||
| To build the application locally, clone this repo to your machine. Then, cd to the directory in terminal and run the following commands to configure the build environment and build the application |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the original sentence because we use it entirely in our repositories, sorry!
| ## Building and Installation | ||
|
|
||
| You'll need the following dependencies: | ||
| You'll need the following dependencies. Use your package manager (apt) to install them: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep the original sentence for distro-agnostic, i.e. not all people who read this README use elementary OS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No prob! Makes sense
LuminousHustler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we're good now, I clicked the "+" button beside the original lines which I think reverts my additions but I'm not entirely sure. Here goes nothing!
Added gettext dependency