Skip to content

Conversation

@danirabbit
Copy link
Member

@danirabbit danirabbit commented Oct 30, 2025

There's likely a race here that makes the applications menu unpin items if the dock isn't loaded yet

@danirabbit danirabbit requested a review from a team October 30, 2025 22:08
@danirabbit danirabbit moved this to Needs review in OS 8.1.0 Oct 30, 2025
@LuminousHustler
Copy link
Contributor

I don't think this PR addresses the bug outlined in elementary/dock#520 (comment). In an effort to triple check that my local build was working correct, I made a local change to App.vala on my machine. To do this I did the following:

  1. Cloned the repo
  2. Downloaded your app.vala raw file from this PR
  3. I changed the label on line 251 to include "this is a test" before building the application locally

My goal was to make 100% sure that the build I was using, indeed had your patches in there....which it did. I then went ahead and ran my tests in elementary/dock#520 (comment)

Anyways, this is a screenshot of what I would see when I used this patched app.vala with my own change to the context menu item.

Screenshot from 2025-11-22 15 25 17 [App.vala.txt](https://github.com/user-attachments/files/23691851/App.vala.txt)

I renamed app.vala to app.vala.txt so the upload to github would work. But yea, it's the same file minus line 251.

Screenshot from 2025-11-22 15 37 02

@danirabbit danirabbit removed this from OS 8.1.0 Dec 1, 2025
@danirabbit danirabbit moved this to Needs review in OS 8.1.1 Dec 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Needs review

Development

Successfully merging this pull request may close these issues.

2 participants