Show a "progress" dialog while invites are being sent #30561
Merged
+269
−79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
force-pushed
the
rav/invite_progress
branch
from
a35bba8 to
dd46c92
Compare
richvdh
force-pushed
the
rav/invite_progress
branch
from
dd46c92 to
10569bc
Compare
If we don't handle rejected promises, jest gets confused by them. Instead, let's create them on-demand.
richvdh
force-pushed
the
rav/invite_progress
branch
from
10569bc to
58f1893
Compare
florianduros
previously requested changes
Aug 14, 2025
… open ... otherwise the `RoomUpgradeWarning` dialog disappears during the invites, and the tests that assert that it is showing the correct thing fail. enter the commit message for your changes. Lines starting
richvdh
force-pushed
the
rav/invite_progress
branch
from
55704e8 to
0541b7a
Compare
richvdh
force-pushed
the
rav/invite_progress
branch
from
0ab7059 to
a646f35
Compare
This reverts commit b0a15d9.
|
@florianduros would you mind taking another look? |
3 tasks
MidhunSureshR
approved these changes
Aug 21, 2025
| import InviteProgressBody from "./InviteProgressBody.tsx"; | ||
|
|
||
| interface Props { | ||
| onFinished: () => void; |
There was a problem hiding this comment.
Would be nice to have a comment here explaining that this is only added because Modal.createDialog expects this component to have this prop.
There was a problem hiding this comment.
Actually it's not needed at all. I'll get rid of it.
| } | ||
|
|
||
| /** A Modal dialog that pops up while room invites are being sent. */ | ||
| const InviteProgressDialog: React.FC<Props> = (props) => { |
There was a problem hiding this comment.
Suggested change
| const InviteProgressDialog: React.FC<Props> = (props) => { | |
| const InviteProgressDialog: React.FC<Props> = (_) => { |
To make it clear that this is intentionally left unused.
| @@ -0,0 +1,27 @@ | |||
| /* | |||
| Copyright 2025 The Matrix.org Foundation C.I.C. | |||
There was a problem hiding this comment.
wrong license I think, newer test files have:
/*
* Copyright 2025 New Vector Ltd.
*
* SPDX-License-Identifier: AGPL-3.0-only OR GPL-3.0-only OR LicenseRef-Element-Commercial
* Please see LICENSE files in the repository root for full details.
*/There was a problem hiding this comment.
What actually changed here?
There was a problem hiding this comment.
heh, great question. Here's the diff:
Looks like a sub-pixel difference in some of the text.
richvdh
force-pushed
the
rav/invite_progress
branch
from
58121a2 to
f72e3e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the EW part of element-hq/element-meta#2874
There are two modes. First, when you are sending invites from the
InviteDialog, the content of the dialog is replaced with a spinner. (Currently a small spinner appears at the top of the dialog but the contents are otherwise unchanged.) Screenshot:Second, for modes of sending invites that don't involve the
InviteDialog, we open a separate modal.