Skip to content

Conversation

Half-Shot
Copy link
Member

@Half-Shot Half-Shot commented Aug 11, 2025

Trivial fix to send you to the correct settings tab when you are told to go enable your integrations.

Review commit-by-commit, 61a0f83 provides the fix and 5dc1f8c does a fly-by convert to a functional component.

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Copy link
Member

@MidhunSureshR MidhunSureshR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but low test coverage will block merge even though in actuality the only added change is a dispatch call.

@Half-Shot Half-Shot added this pull request to the merge queue Aug 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2025
@Half-Shot Half-Shot added this pull request to the merge queue Aug 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2025
@Half-Shot Half-Shot added this pull request to the merge queue Aug 27, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2025
Merged via the queue into develop with commit 4d48d1b Sep 1, 2025
35 checks passed
@Half-Shot Half-Shot deleted the hs/take-to-integration-settings branch September 1, 2025 07:47
@Half-Shot
Copy link
Member Author

Finally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants