Skip to content

Remove deprecated target arch API #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
malept merged 2 commits into from
Dec 4, 2018
Merged

Remove deprecated target arch API #915

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e70aedc
Remove deprecated target arch API
malept Dec 4, 2018
d61bb11
Deleted too much
malept Dec 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions targets.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
'use strict'

const common = require('./common')
const downloadArch = require('electron-download/lib/arch')
const hostArch = require('electron-download/lib/arch').host
const semver = require('semver')

const officialArchs = ['ia32', 'x64', 'armv7l', 'arm64', 'mips64el']
Expand Down Expand Up @@ -93,13 +93,11 @@ module.exports = {
return archs
},
createPlatformArchPairs: createPlatformArchPairs,
hostArch: downloadArch.host,
officialArchs: officialArchs,
officialPlatformArchCombos: officialPlatformArchCombos,
officialPlatforms: officialPlatforms,
osModules: osModules,
supported: supported,
unameArch: downloadArch.uname,
// Validates list of architectures or platforms.
// Returns a normalized array if successful, or throws an Error.
validateListFromOptions: function validateListFromOptions (opts, name) {
Expand All @@ -108,7 +106,7 @@ module.exports = {
let list = opts[name]
if (!list) {
if (name === 'arch') {
list = module.exports.hostArch()
list = hostArch()
} else {
list = process[name]
}
Expand Down