Skip to content

Conversation

@malept
Copy link
Member

@malept malept commented Oct 1, 2018

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Don't try to modify helper plists, etc., if they don't exist.

Tested manually with the latest 4.0 nightly. (I'm not using that in the tests because the testsuite downloads way too many Electron versions as it is.)

@malept malept requested a review from MarshallOfSound October 1, 2018 15:40
@codecov
Copy link

codecov bot commented Oct 2, 2018

Codecov Report

Merging #894 into master will increase coverage by 5.51%.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #894      +/-   ##
========================================
+ Coverage   94.48%   100%   +5.51%     
========================================
  Files          12     12              
  Lines         617    619       +2     
========================================
+ Hits          583    619      +36     
+ Misses         34      0      -34
Impacted Files Coverage Δ
mac.js 100% <100%> (+24.26%) ⬆️
ignore.js 100% <0%> (+2.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ca0e9...7f04d47. Read the comment docs.

@malept malept merged commit e3f18ec into master Oct 2, 2018
@malept malept deleted the optional-helpers branch October 2, 2018 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants