Consolidate electron-download options #320
Conversation
malept
added
the
blocked 🚫
malept
force-pushed
the
consolidate-download-options
branch
from
131e0ae to
412d53f
Compare
malept
removed
the
blocked 🚫
malept
force-pushed
the
consolidate-download-options
branch
from
412d53f to
cd3f488
Compare
|
This is in a better spot to be reviewed now, using the normal UI. |
| 'download.strictSSL' | ||
| ], | ||
| default: { | ||
| 'strict-ssl': true, |
There was a problem hiding this comment.
This actually fixes a bug with strict-ssl 😢
There was a problem hiding this comment.
This should probably use the alias feature of minimist, so the two values are always in sync. Otherwise, the other default might overwrite the user setting.
There was a problem hiding this comment.
Yeah, wow. Good catch. This means that users using electron-packager v6 from the command line will accept invalid ssl certificates.
This is bad enough that I would recommend running npm deprecate on all older versions so users know to upgrade.
There was a problem hiding this comment.
This should probably use the
aliasfeature of minimist, so the two values are always in sync. Otherwise, the other default might overwrite the user setting.
Hmm. I'll have to look into that, thanks.
malept
force-pushed
the
consolidate-download-options
branch
from
bc35b61 to
ebea1d8
Compare
| 'download.strictSSL' | ||
| ], | ||
| default: { | ||
| 'strict-ssl': true, |
There was a problem hiding this comment.
All versions or just 6.x?
3 participants
Consolidates
cacheandstrict-sslinto the newdownloadparameter, which is more or less passed directly toelectron-download(similar toosx-signandversion-string). The original two parameters are now deprecated. This also lets us easily add sub-properties such asmirror(as requested in #316).Depends on #319
, so this might be a better diff to look at until it's merged.Closes #316.