Delete default_app.asar during packaging #298
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Electron 0.37.4 is now out so |
Member
|
We've just added a 0.37.4 fixture via #301. Would you mind adding a testcase using that test project to make sure that Once that's done, I'd like to merge this PR and release 6.0.1. |
Contributor
Author
|
@malept What Electron version do the basic tests run against by default? Is the current test in this pull request not sufficient? |
Member
|
@kevinsawicki the basic tests run against 0.35.4 or so, I believe due to the Mac App Store target platform. |
Member
|
I would rather have a test for Electron versions both before and after 0.37.4, to ensure both cases are covered. |
This was referenced Apr 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the next Electron release (0.37.4), the
default_app/folder will now be adefault_app.asarfile.This pull request adds support for deleting
default_app.asarduring packaging.electron/electron#4956