Simple fix for issue 242: Info.plist issues with CFBundleVersion #250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR! Could you add a test? |
Member
|
Also, once this is approved to be merged, could you squash the commits? |
Ensure that CFBundleVersion and CFBundleShortVersionString are both stored as strings, even if the app-version or build-version options are integers. Style issue: spaces around +. Added a test.
Author
|
Test and squash. Enjoy. |
Member
|
Minor nit: you don't really need the last two lines in your commit, even though they came from the original unsquashed commits. Apart from that, 👍 |
malept
added a commit
that referenced
this pull request
Feb 5, 2016
Simple fix for issue 242: Info.plist issues with CFBundleVersion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that CFBundleVersion and CFBundleShortVersionString are
both stored as strings, even if the app-version or build-version
options are integers.
#242