Skip to content

Conversation

@erickzhao
Copy link
Member

@erickzhao erickzhao commented Sep 18, 2025

BREAKING CHANGE: All hooks return Promises rather than using callbacks for async work. Hook function parameters are now keys on an options object instead of taking positional args.

const myHookFn = async ({ buildPath, electronVersion, platform, arch }) => {
   await someAsyncHelper(buildPath);
}

Converts all hooks from callback-based to Promise-based. Renames promisifyHooks to runHooks for simplicity. serialHooks utility remains the same.

@erickzhao erickzhao changed the title Promisify hooks feat!: promisify hooks Sep 18, 2025
@erickzhao erickzhao marked this pull request as ready for review September 18, 2025 21:46
@erickzhao erickzhao requested a review from a team as a code owner September 18, 2025 21:46
Base automatically changed from better-types to main September 18, 2025 22:01
@MarshallOfSound MarshallOfSound merged commit 623a49c into main Oct 3, 2025
8 checks passed
@MarshallOfSound MarshallOfSound deleted the promisify-hooks branch October 3, 2025 20:05
@continuous-auth
Copy link

🎉 This PR is included in version 19.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants