test: use config.version Electron whenever possible

[erickzhao]

Should fix up test stability a bit, where we were getting errors when running platform=all on an Electron version that wasn't properly pre-downloaded.

This regressed after 03347ec upgraded the pre-downloaded Electron version to v27.0.0 but kept a few tests on v1.4.13. With DEBUG variables, we can see this in action:

2024-06-25T15:43:47.632Z electron-packager Downloading Electron with options {"platform":"linux","arch":"ia32","version":"1.4.13","artifactName":"electron"}
2024-06-25T15:43:47.633Z electron-packager Downloading Electron with options {"platform":"win32","arch":"ia32","version":"1.4.13","artifactName":"electron"}
2024-06-25T15:43:47.633Z @electron/get:index Checking the cache (undefined) for electron-v1.4.13-linux-ia32.zip (https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-linux-ia32.zip)
2024-06-25T15:43:47.634Z @electron/get:index Checking the cache (undefined) for electron-v1.4.13-win32-ia32.zip (https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-win32-ia32.zip)
2024-06-25T15:43:47.634Z @electron/get:index Cache miss
2024-06-25T15:43:47.634Z @electron/get:index Cache miss
2024-06-25T15:43:47.635Z @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-linux-ia32.zip to C:\Users\circleci\AppData\Local\Temp\electron-download-rCjw2l\electron-v1.4.13-linux-ia32.zip with options: undefined
2024-06-25T15:43:47.635Z @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/electron-v1.4.13-win32-ia32.zip to C:\Users\circleci\AppData\Local\Temp\electron-download-tpSEU8\electron-v1.4.13-win32-ia32.zip with options: undefined
2024-06-25T15:43:48.886Z @electron/get:index Checking the cache (undefined) for SHASUMS256.txt (https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt)
2024-06-25T15:43:48.887Z @electron/get:index Cache miss
2024-06-25T15:43:48.914Z @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt to C:\Users\circleci\AppData\Local\Temp\electron-download-XKeViw\SHASUMS256.txt with options: undefined
2024-06-25T15:43:48.915Z @electron/get:index Checking the cache (undefined) for SHASUMS256.txt (https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt)
2024-06-25T15:43:48.915Z @electron/get:index Cache miss
2024-06-25T15:43:48.927Z @electron/get:index Downloading https://github.com/electron/electron/releases/download/v1.4.13/SHASUMS256.txt to C:\Users\circleci\AppData\Local\Temp\electron-download-R7RsCY\SHASUMS256.txt with options: undefined
2024-06-25T15:43:49.196Z @electron/get:cache Moving C:\Users\circleci\AppData\Local\Temp\electron-download-XKeViw\SHASUMS256.txt to C:\Users\circleci\AppData\Local\electron\Cache\4660c2617dcac48c05988e181e4f7ff85132cd278bba79561816d3e7da1cc50c\SHASUMS256.txt
2024-06-25T15:43:49.199Z @electron/get:cache Moving C:\Users\circleci\AppData\Local\Temp\electron-download-R7RsCY\SHASUMS256.txt to C:\Users\circleci\AppData\Local\electron\Cache\4660c2617dcac48c05988e181e4f7ff85132cd278bba79561816d3e7da1cc50c\SHASUMS256.txt
  × platform=all (one arch) for beforeCopy hook Rejected promise returned by test

@electron/get is colliding on SHASUMS256.txt, similar to what we found in #1540. The fix applied for that PR regressed for the aforementioned reason, but the underlying logic for this change is similar.

We should also file this bug as a separate issue on the issue tracker. ref #1552

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.06%. Comparing base (2f92bbd) to head (377f5ca).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1740      +/-   ##
==========================================
- Coverage   89.28%   89.06%   -0.23%     
==========================================
  Files          17       17              
  Lines         905      905              
  Branches      187      187              
==========================================
- Hits          808      806       -2     
- Misses         61       62       +1     
- Partials       36       37       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[dsanders11]

Nice! This has been a thorn for a while now, thanks for fixing it. 👍

[continuous-auth]

🎉 This PR is included in version 18.3.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀