Skip to content

Conversation

@MarshallOfSound
Copy link
Member

Packager didn't use unique staging / temp directories so running packager twice with similar targets would cause issues.

@erickzhao erickzhao requested a review from a team November 1, 2022 21:14
Copy link
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failing CI looks like a flake

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1439 (d90c8c9) into main (c772bff) will increase coverage by 0.03%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main    #1439      +/-   ##
==========================================
+ Coverage   95.54%   95.58%   +0.03%     
==========================================
  Files          15       15              
  Lines         786      792       +6     
==========================================
+ Hits          751      757       +6     
  Misses         35       35              
Impacted Files Coverage Δ
src/index.js 98.97% <83.33%> (+0.02%) ⬆️
src/platform.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MarshallOfSound MarshallOfSound merged commit 745d286 into main Nov 1, 2022
@MarshallOfSound MarshallOfSound deleted the fix-simul-package branch November 1, 2022 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants