Skip to content

feat: add new afterFinalizePackageTargets hook #1437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
MarshallOfSound merged 3 commits into from
Oct 31, 2022
Merged

feat: add new afterFinalizePackageTargets hook #1437

MarshallOfSound merged 3 commits into from
Oct 31, 2022

Conversation

@MarshallOfSound
Copy link
Member

@MarshallOfSound MarshallOfSound commented Oct 27, 2022

@MarshallOfSound MarshallOfSound requested a review from a team October 27, 2022 23:27
@MarshallOfSound MarshallOfSound mentioned this pull request Oct 27, 2022
Merged
5 tasks
@erickzhao erickzhao self-requested a review October 27, 2022 23:36
@MarshallOfSound MarshallOfSound force-pushed the afterFinalizeTargetMatrix branch from 68c8af8 to 05decd1 Compare October 27, 2022 23:49
@MarshallOfSound MarshallOfSound force-pushed the afterFinalizeTargetMatrix branch from 05decd1 to 9c5e647 Compare October 28, 2022 00:01
@codecov
Copy link

codecov bot commented Oct 28, 2022 •
edited
Loading

Codecov Report

Merging #1437 (86fc90d) into main (5aac8c9) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1437      +/-   ##
==========================================
+ Coverage   95.41%   95.54%   +0.13%     
==========================================
  Files          15       15              
  Lines         785      786       +1     
==========================================
+ Hits          749      751       +2     
+ Misses         36       35       -1
Impacted Files Coverage Δ
src/index.js 98.95% <100.00%> (+0.01%) ⬆️
src/copy-filter.js 100.00% <0.00%> (+2.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

georgexu99
georgexu99 reviewed Oct 28, 2022
View reviewed changes
@malept
Copy link
Member

malept commented Oct 28, 2022

🚲🏚️ hook name:

  • success
  • complete
  • allDone

Something along those lines.

@MarshallOfSound
Copy link
Member Author

MarshallOfSound commented Oct 28, 2022

@malept this hook is called before any packaging is actually done

erickzhao
erickzhao reviewed Oct 28, 2022
View reviewed changes
@malept
Copy link
Member

malept commented Oct 28, 2022 •
edited
Loading

this hook is called before any packaging is actually done

Hrm, I misread the Forge issue. afterTargetCalculation or something similar?

macdja38
macdja38 reviewed Oct 29, 2022
View reviewed changes
@MarshallOfSound MarshallOfSound changed the title feat: add new afterFinalizeTargetMatrix hook feat: add new afterFinalizePackageTargets hook Oct 31, 2022
@MarshallOfSound MarshallOfSound merged commit fff1487 into main Oct 31, 2022
@MarshallOfSound MarshallOfSound deleted the afterFinalizeTargetMatrix branch October 31, 2022 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@georgexu99 georgexu99 georgexu99 left review comments

@VerteDinde VerteDinde VerteDinde approved these changes

@erickzhao erickzhao erickzhao approved these changes

+1 more reviewer

@macdja38 macdja38 macdja38 left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@MarshallOfSound @malept @VerteDinde @macdja38 @erickzhao @georgexu99