Skip to content

Conversation

@erikian
Copy link
Member

@erikian erikian commented Oct 28, 2021

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:
This PR partially addresses #509 with the following new lifecycle methods: afterAsar, afterComplete, afterCopyExtraResources, beforeAsar, beforeCopy, beforeCopyExtraResources. There's definitely room for improvement, so any feedback is welcome.

@welcome
Copy link

welcome bot commented Oct 28, 2021

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

@codecov
Copy link

codecov bot commented Oct 28, 2021

Codecov Report

Merging #1297 (1a93df3) into main (21bb953) will increase coverage by 0.06%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1297      +/-   ##
==========================================
+ Coverage   95.47%   95.54%   +0.06%     
==========================================
  Files          15       15              
  Lines         774      785      +11     
==========================================
+ Hits          739      750      +11     
  Misses         35       35              
Impacted Files Coverage Δ
src/platform.js 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@erikian erikian changed the title New lifecycle hooks: afterAsar, afterComplete, afterCopyExtraResources, beforeAsar, beforeCopy, beforeCopyExtraResources feat: New lifecycle hooks: afterAsar, afterComplete, afterCopyExtraResources, beforeAsar, beforeCopy, beforeCopyExtraResources Jan 16, 2022
@erikian
Copy link
Member Author

erikian commented Jan 26, 2022

If there's anything I can do to help move this along, please let me know. 🙂

@erickzhao erickzhao requested a review from a team February 3, 2022 02:04
@VerteDinde VerteDinde force-pushed the main branch 2 times, most recently from e3c0490 to 300566f Compare October 19, 2022 23:55
@erikian erikian requested a review from erickzhao October 25, 2022 11:54
@VerteDinde VerteDinde merged commit 5aac8c9 into electron:main Oct 25, 2022
@welcome
Copy link

welcome bot commented Oct 25, 2022

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants