feat: automatically insert ElectronAsarIntegrity into Info.plist #1279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1279 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 726 733 +7
=========================================
+ Hits 726 733 +7
Continue to review full report at Codecov.
|
malept
requested changes
Sep 9, 2021
Member
malept
left a comment
malept
left a comment
There was a problem hiding this comment.
This looks reasonable, but I'd like some tests added as well.
Member
Author
|
@malept Tests added 👍 |
malept
approved these changes
Sep 9, 2021
Member
malept
left a comment
malept
left a comment
There was a problem hiding this comment.
I will try to make a new release tonight or tomorrow.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs electron/electron#30667
Small addition to automatically insert the new (currently optional)
ElectronAsarIntegrityblock into your Info.plist