-
-
Notifications
You must be signed in to change notification settings - Fork 29
fix(copy-filter): add package manager lockfiles to default ignore #1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for opening a pull request! Here are some highlighted action items that will help get it across the finish line, from the
Development and triage is community-driven, so please be patient and we will get back to you as soon as we can. |
b39e7bd to
aeb455f
Compare
Codecov Report
@@ Coverage Diff @@
## master #1182 +/- ##
===========================================
+ Coverage 99.85% 100.00% +0.14%
===========================================
Files 14 14
Lines 698 698
===========================================
+ Hits 697 698 +1
+ Misses 1 0 -1
Continue to review full report at Codecov.
|
malept
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this PR! This approach generally works, but I have some suggestions that will make it more robust that I'd like to get in before we merge this (mainly regarding the test that was added).
d5750e2 to
062f619
Compare
|
Sorry about the force push - I pushed a commit from the wrong git account. |
malept
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
|
Thanks for your contribution! 🎉 |
Summarize your changes:
Added
package-lock.jsonandyarn.lockto the default ignored file regex.