Skip to content

Conversation

@emab
Copy link
Contributor

@emab emab commented Oct 3, 2020

  • I have read the contribution documentation for this project.
  • I agree to follow the code of conduct that this project follows, as appropriate.
  • The changes are appropriately documented (if applicable).
  • The changes have sufficient test coverage (if applicable).
  • The testsuite passes successfully on my local machine (if applicable).

Summarize your changes:

Added package-lock.json and yarn.lock to the default ignored file regex.

@welcome
Copy link

welcome bot commented Oct 3, 2020

Thanks for opening a pull request!

Here are some highlighted action items that will help get it across the finish line, from the
pull request guidelines:

  • Follow the JavaScript coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes in NEWS.md and other docs.
  • Include tests when adding/changing behavior.

Development and triage is community-driven, so please be patient and we will get back to you as soon as we can.

@emab emab changed the title Add package manager lockfiles to default ignore fix: Add package manager lockfiles to default ignore Oct 3, 2020
@emab emab force-pushed the add-lockfile-ignore branch from b39e7bd to aeb455f Compare October 3, 2020 09:54
@codecov
Copy link

codecov bot commented Oct 3, 2020

Codecov Report

Merging #1182 into master will increase coverage by 0.14%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #1182      +/-   ##
===========================================
+ Coverage   99.85%   100.00%   +0.14%     
===========================================
  Files          14        14              
  Lines         698       698              
===========================================
+ Hits          697       698       +1     
+ Misses          1         0       -1     
Impacted Files Coverage Δ
src/copy-filter.js 100.00% <ø> (+2.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6433299...5fd0a43. Read the comment docs.

@malept malept changed the title fix: Add package manager lockfiles to default ignore fix: add package manager lockfiles to default ignore Oct 3, 2020
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this PR! This approach generally works, but I have some suggestions that will make it more robust that I'd like to get in before we merge this (mainly regarding the test that was added).

@malept malept changed the title fix: add package manager lockfiles to default ignore fix(copy-filter): add package manager lockfiles to default ignore Oct 6, 2020
@emab emab force-pushed the add-lockfile-ignore branch from d5750e2 to 062f619 Compare October 6, 2020 13:04
@emab
Copy link
Contributor Author

emab commented Oct 6, 2020

Sorry about the force push - I pushed a commit from the wrong git account.

@emab emab requested a review from malept October 6, 2020 21:59
Copy link
Member

@malept malept left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@malept malept merged commit f1c159f into electron:master Oct 9, 2020
@welcome
Copy link

welcome bot commented Oct 9, 2020

Thanks for your contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants