Skip to content

Conversation

@AnthonyLloydDotNet
Copy link

follow-up to #915

created a separate branch that only includes this change

REQUIRES FFMPEG.EXE IN MAIN PROJECT FOLDER

video example

@JasonLovesDoggo
Copy link
Collaborator

The problem here is that it requires FFMPEG In the main project folder If you bypass that then there was a serious chance this could get merged

@efa2d19
Copy link
Contributor

efa2d19 commented Jul 14, 2022

@JasonLovesDoggo @tonywiththetommy
there is FFMPEG in dependencies tho, not a biggie)

you can use that

import imageio_ffmpeg

imageio_ffmpeg.get_ffmpeg_exe()

@JasonLovesDoggo
Copy link
Collaborator

@JasonLovesDoggo @tonywiththetommy
there is FFMPEG in dependencies tho, not a biggie)

you can use that

import imageio_ffmpeg

imageio_ffmpeg.get_ffmpeg_exe()

Awesome!

@efa2d19
Copy link
Contributor

efa2d19 commented Jul 14, 2022

I don't think the problem is in concat method, I believe it's in split text and inability of TTS (TikTik's at least) to read dots at the end.
If you'll look closely, you can spot it in the video, there are 2 dots:

  • one after 12 pack of milk cartons and put them in one by one.
  • and another one after that day everyone did it my way.

upd: nah, I checked, it's not the problem, at least at the end of clips

@callumio callumio changed the base branch from master to develop July 17, 2022 18:51
@JasonLovesDoggo
Copy link
Collaborator

Merge conflicts

@JasonLovesDoggo JasonLovesDoggo added the merge conflicts PR is ready to be merged once conflicts are resolved label Jul 22, 2022
@github-actions github-actions bot added the stale label Jul 29, 2022
@JasonLovesDoggo
Copy link
Collaborator

See #1177

JasonLovesDoggo added a commit that referenced this pull request Aug 22, 2022
Minor changes to #990 (fixed audio glitches caused by previous audio concatenation method)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflicts PR is ready to be merged once conflicts are resolved stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants