Better explanations, examples, choice to voice_choice #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonLovesDoggo
requested changes
Jul 14, 2022
bobcat4848
commented
Jul 17, 2022
Contributor
Author
bobcat4848
left a comment
bobcat4848
left a comment
There was a problem hiding this comment.
Change made, please re-review if you do not mind.
Collaborator
You should have pinged me I didn't notice |
JasonLovesDoggo
requested changes
Jul 18, 2022
Collaborator
JasonLovesDoggo
left a comment
JasonLovesDoggo
left a comment
There was a problem hiding this comment.
This is fine now You just need to add the new background options into this as well (see develop branch for said options)
bobcat4848
commented
Jul 20, 2022
Contributor
Author
bobcat4848
left a comment
bobcat4848
left a comment
There was a problem hiding this comment.
Made changes @JasonLovesDoggo
JasonLovesDoggo
approved these changes
Jul 20, 2022
Collaborator
JasonLovesDoggo
left a comment
JasonLovesDoggo
left a comment
There was a problem hiding this comment.
There is a merge conflict though
JasonLovesDoggo
added
before next release
Collaborator
|
Fix the merge conflicts and I can merge |
9 tasks
Collaborator
|
See #1076 Sorry bob.. |
JasonLovesDoggo
added a commit
that referenced
this pull request
Jul 26, 2022
Fixed merge conflicts from #982
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Better explanations and examples that make more sense to less tech-savvy users of the program. Changed naming of configuration variable choice to voice_choice to make it clearer to user as well. Formatted the toml configuration file better for easier readability, each property is on its own line instead of spanning over multiple.
Issue Fixes
None
Checklist:
Any other information (e.g how to test the changes)
None