Add approximate execution time on the result panel header #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds an approximate execution time display to the result panel header so that users can compare execution efficiency alongside the results.
- Updated state initialization style in playground.js.
- Added new CSS and HTML markup in the result panel for displaying execution time.
- Extended error and execution result tests in ottlplayground_test.go and updated the execution result flow in ottlplayground.go.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| web/src/components/playground.js | Improved code style with consistent semicolon and arrow function usage. |
| web/src/components/panels/result-panel.styles.js | Added a new style block for the execution time header. |
| web/src/components/panels/result-panel.js | Inserted UI component for showing execution time in the header. |
| wasm/internal/ottlplayground_test.go | Updated tests to validate the inclusion and value of executionTime. |
| wasm/internal/ottlplayground.go | Modified functions to propagate the executionTime measurement. |
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
edmocosta
force-pushed
the
add-execution-time-header
branch
from
02b7580 to
20973a0
Compare
|
Thank you for the suggestion, @jaronoff97 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the configuration execution time (milliseconds) on the result panel header, so users can compare their approximate execution time and roughly compare their efficiency.