-
Notifications
You must be signed in to change notification settings - Fork 38
feat: add confighttp configuration with TLS support #596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Now that we are introducing configuration breaking changes (and before adding it to EDOT), I would like to rename the |
(Take my feedback with a grain of salt. I have almost no experience with naming OTel Collector-y things.) Do these config settings need to be namespaced under
? On the subject of naming: Is there a reason this extension is named |
It's not strictly necessary, but in my opinion, it provides a useful way to distinguish the two core responsibilities of the extension:
I actually believe it could be a candidate for upstreaming. The OpAMP server is designed to be agnostic with respect to the remote configuration fetcher/provider. It relies on a client interface that can be implemented by various fetchers—Elasticsearch being one example (see the Otel parameters here: https://github.com/elastic/opentelemetry-collector-components/blob/main/extension/apmconfigextension/apmconfig/client.go#L39) Indeed, since agent_config is a map, it could be extended to support other providers or fetchers in the future: extensions:
apmconfig:
agent_config:
kibana:
endpoint: http://localhost:9200 Or another vendor: extensions:
apmconfig:
agent_config:
other_vendor:
url: http://localhost:9200 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes: #595
Breaking change in all configurations, from:
The new configuration uses a similar approach as the OTLP receiver, where multiple protocols can run simultaneously. Having in mind that Websockets protocol is supported by OpAMP and might be implemented in the future:
In addition, the confighttp configuration is used to create the server, thus leveraging all its features (TLS, authentication, CORS, timeout, etc).