-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Exposes average batch metrics at 1, 5 and 15 minutes time window. #18460
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andsel
merged 7 commits into
elastic:main
from
andsel:feature/expose_batch_metrics_time_windows
Dec 11, 2025
+22
−4
Merged
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
e083753
Updates stats API response to expose also 1m, 5m and 15m average batc…
andsel f865a53
[Test] Added DSL definition to verify structure of the time windows
andsel c22c384
[Doc] Updated sample in openapi definition to include the time windows
andsel 8f2702c
[Test] Revomed verification of batch metric fields that in fast test …
andsel 7a9bd66
Simplified code to iterate over the time windows while constructing A…
andsel aa029b9
Fixed doc typos in describing API response
andsel ebd0814
Better wording for code comment
andsel File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having a hard time parsing this comment, not sure exactly what the message is supposed to convey.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's more a reminder for the reader why for this metric we need to invoke the
getValuemethod.The reason why resides in the fact that the flow metric nested in
batch/[event_count | byte_szie]/average, to return the sub-document which contains thelifetime,last_1_minuteetc metric values needs to be explicitly queried to return the map with those values:logstash/logstash-core/src/main/java/org/logstash/instrument/metrics/ExtendedFlowMetric.java
Line 89 in 279171b
Usually the paths drive to single value metric objects, but this a composite that needs explicit query to grab the contained values.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@donoghuc let me know if you want me to reword the sentence so that could sound more meaningful (a good suggestion from a native speaker is very welcome :-) )