Skip to content

fix(core): Use absolute string anchors in regex to prevent multi-line validation bypass #18415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
odaysec wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(core): Use absolute string anchors in regex to prevent multi-line validation bypass #18415

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion logstash-core/lib/logstash/util/thread_safe_attributes.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ module Util
module ThreadSafeAttributes
# Thread-safe lazy initialized attribute with a given (variable) name.
def lazy_init_attr(attribute, variable: "@#{attribute}".to_sym, &block)
raise ArgumentError.new("invalid attribute name: #{attribute}") unless attribute.match? /^[_A-Za-z]\w*$/
raise ArgumentError.new("invalid attribute name: #{attribute}") unless attribute.match? /\A[_A-Za-z]\w*\z/
raise ArgumentError.new('no block given') unless block_given?
send(:define_method, attribute.to_sym) do
if instance_variable_defined?(variable)
Expand Down