Replace buildkite jdk version check w/GH action #17945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donoghuc
added
the
backport-active-all
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
dliappis
reviewed
Aug 11, 2025
| git push origin $BRANCH | ||
|
|
||
| - name: Create Pull Request | ||
| if: steps.verify-changed-files.outputs.changed == 'true' |
Contributor
There was a problem hiding this comment.
Have you considered an updatecli workflow for this instead? See an example from beats in https://github.com/elastic/beats/tree/1df4889c66c43c71b7a795f7c735eeb79c48c569/.github/workflows/updatecli.d
Member
Author
There was a problem hiding this comment.
I had not heard of that tool before. That looks very helpful! I pinged you in slack to clarify your suggestion for doing testing for worfklows. Once i have that down i can experiment a bit with using updatecli. Thanks!
Member
Author
There was a problem hiding this comment.
Thanks @dliappis again for the review and suggestions. I opened a PR to add a stub action to test against #17993 and started exploring the updatecli tool with #18035
If you have a chance to look at those that would be great. I was thinking we can get the stub action merged which will inform this and the other proposed action.
Contributor
There was a problem hiding this comment.
LGTM for the stub, thanks!
v1v
reviewed
Sep 3, 2025
Member
v1v
left a comment
v1v
left a comment
There was a problem hiding this comment.
LGTM, just a quick comment whether using updatecli could help with creating the PR automatically and deal with the git commands (config, add, commit, push). updatecli is idempotence so it can help with removing the if steps, in addition it can help with the testing, since the GH workflows will just configure the environment (updatecli, secrets, jdk) and run the updatecli apply.
What do you think?
Previously a weekly buildkite job would check if there is a newer JDK available than the one vendored in logstash. This job would fail until someone manually updated the JDK version in the `versions.yml` file in logstash. This commit reduces manual intervention by moving the responsibility to a GH action where there are patterns for creating PRs back to logstash. The action should run weekly and also be available in the actions UI. It is locked down with the same permissions as the version bump action.
donoghuc
force-pushed
the
java-bump-action
branch
from
507cf48 to
f288911
Compare
Member
Author
|
@v1v I refactored this PR to use pure updatecli and remove the gradle task all together. Here is a run of the workflow https://github.com/elastic/logstash/actions/runs/17986277124/job/51165121366 |
donoghuc
commented
Sep 24, 2025
v1v
reviewed
Sep 24, 2025
v1v
approved these changes
Sep 24, 2025
|
Contributor
|
@Mergifyio backport 8.18 8.19 9.0 9.1 |
Contributor
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Replace buildkite jdk version check w/GH action Previously a weekly buildkite job would check if there is a newer JDK available than the one vendored in logstash. This job would fail until someone manually updated the JDK version in the `versions.yml` file in logstash. This commit reduces manual intervention by moving the responsibility to a GH action where there are patterns for creating PRs back to logstash. The action should run weekly and also be available in the actions UI. It is locked down with the same permissions as the version bump action. * Refactor to use updatecli * Remove gradle task in favor of updatecli * remove unused file * Dynamically generate java version lookup * make pipeline name unique' ' (cherry picked from commit 2fab5f4) # Conflicts: # build.gradle # catalog-info.yaml
5 tasks
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Replace buildkite jdk version check w/GH action Previously a weekly buildkite job would check if there is a newer JDK available than the one vendored in logstash. This job would fail until someone manually updated the JDK version in the `versions.yml` file in logstash. This commit reduces manual intervention by moving the responsibility to a GH action where there are patterns for creating PRs back to logstash. The action should run weekly and also be available in the actions UI. It is locked down with the same permissions as the version bump action. * Refactor to use updatecli * Remove gradle task in favor of updatecli * remove unused file * Dynamically generate java version lookup * make pipeline name unique' ' (cherry picked from commit 2fab5f4) # Conflicts: # catalog-info.yaml
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Replace buildkite jdk version check w/GH action Previously a weekly buildkite job would check if there is a newer JDK available than the one vendored in logstash. This job would fail until someone manually updated the JDK version in the `versions.yml` file in logstash. This commit reduces manual intervention by moving the responsibility to a GH action where there are patterns for creating PRs back to logstash. The action should run weekly and also be available in the actions UI. It is locked down with the same permissions as the version bump action. * Refactor to use updatecli * Remove gradle task in favor of updatecli * remove unused file * Dynamically generate java version lookup * make pipeline name unique' ' (cherry picked from commit 2fab5f4) # Conflicts: # catalog-info.yaml
This was referenced Sep 24, 2025
💚 Build Succeeded
History
|
mergify bot
pushed a commit
that referenced
this pull request
Sep 24, 2025
* Replace buildkite jdk version check w/GH action Previously a weekly buildkite job would check if there is a newer JDK available than the one vendored in logstash. This job would fail until someone manually updated the JDK version in the `versions.yml` file in logstash. This commit reduces manual intervention by moving the responsibility to a GH action where there are patterns for creating PRs back to logstash. The action should run weekly and also be available in the actions UI. It is locked down with the same permissions as the version bump action. * Refactor to use updatecli * Remove gradle task in favor of updatecli * remove unused file * Dynamically generate java version lookup * make pipeline name unique' ' (cherry picked from commit 2fab5f4)
5 tasks
donoghuc
added a commit
that referenced
this pull request
Sep 24, 2025
* Replace buildkite jdk version check w/GH action Previously a weekly buildkite job would check if there is a newer JDK available than the one vendored in logstash. This job would fail until someone manually updated the JDK version in the `versions.yml` file in logstash. This commit reduces manual intervention by moving the responsibility to a GH action where there are patterns for creating PRs back to logstash. The action should run weekly and also be available in the actions UI. It is locked down with the same permissions as the version bump action. * Refactor to use updatecli * Remove gradle task in favor of updatecli * remove unused file * Dynamically generate java version lookup * make pipeline name unique' ' (cherry picked from commit 2fab5f4) Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 24, 2025
…ion (#18211) * Replace buildkite jdk version check w/GH action (#17945) * Replace buildkite jdk version check w/GH action Previously a weekly buildkite job would check if there is a newer JDK available than the one vendored in logstash. This job would fail until someone manually updated the JDK version in the `versions.yml` file in logstash. This commit reduces manual intervention by moving the responsibility to a GH action where there are patterns for creating PRs back to logstash. The action should run weekly and also be available in the actions UI. It is locked down with the same permissions as the version bump action. * Refactor to use updatecli * Remove gradle task in favor of updatecli * remove unused file * Dynamically generate java version lookup * make pipeline name unique' ' (cherry picked from commit 2fab5f4) # Conflicts: # build.gradle # catalog-info.yaml * fix merge conflicts --------- Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 24, 2025
…ion (#18212) * Replace buildkite jdk version check w/GH action (#17945) * Replace buildkite jdk version check w/GH action Previously a weekly buildkite job would check if there is a newer JDK available than the one vendored in logstash. This job would fail until someone manually updated the JDK version in the `versions.yml` file in logstash. This commit reduces manual intervention by moving the responsibility to a GH action where there are patterns for creating PRs back to logstash. The action should run weekly and also be available in the actions UI. It is locked down with the same permissions as the version bump action. * Refactor to use updatecli * Remove gradle task in favor of updatecli * remove unused file * Dynamically generate java version lookup * make pipeline name unique' ' (cherry picked from commit 2fab5f4) # Conflicts: # catalog-info.yaml * fix merge conflicts --------- Co-authored-by: Cas Donoghue <[email protected]>
donoghuc
added a commit
that referenced
this pull request
Sep 24, 2025
…on (#18213) * Replace buildkite jdk version check w/GH action (#17945) * Replace buildkite jdk version check w/GH action Previously a weekly buildkite job would check if there is a newer JDK available than the one vendored in logstash. This job would fail until someone manually updated the JDK version in the `versions.yml` file in logstash. This commit reduces manual intervention by moving the responsibility to a GH action where there are patterns for creating PRs back to logstash. The action should run weekly and also be available in the actions UI. It is locked down with the same permissions as the version bump action. * Refactor to use updatecli * Remove gradle task in favor of updatecli * remove unused file * Dynamically generate java version lookup * make pipeline name unique' ' (cherry picked from commit 2fab5f4) # Conflicts: # catalog-info.yaml * fix merge concflicts --------- Co-authored-by: Cas Donoghue <[email protected]>
v1v
pushed a commit
that referenced
this pull request
Oct 21, 2025
* Replace buildkite jdk version check w/GH action Previously a weekly buildkite job would check if there is a newer JDK available than the one vendored in logstash. This job would fail until someone manually updated the JDK version in the `versions.yml` file in logstash. This commit reduces manual intervention by moving the responsibility to a GH action where there are patterns for creating PRs back to logstash. The action should run weekly and also be available in the actions UI. It is locked down with the same permissions as the version bump action. * Refactor to use updatecli * Remove gradle task in favor of updatecli * remove unused file * Dynamically generate java version lookup * make pipeline name unique' '
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release notes
[rn:skip]
What does this PR do?
Previously a weekly buildkite job would check if there is a newer JDK available than the one vendored in logstash. This job would fail until someone manually updated the JDK version in the
versions.ymlfile in logstash. This commit reduces manual intervention by moving the responsibility to a GH action where there are patterns for creating PRs back to logstash. The action should run weekly and also be available in the actions UI. It is locked down with the same permissions as the version bump action. The gradle task has been replaced with the updatecli pattern established in #18035Why is it important/What is the impact to the user?
No user impact, quality of life improvement for logstash devs.
Checklist
How to test this PR locally
Downgrade java version in
versions.ymland run./gradlew updateJdkVersionto update it back to latest.Related issues