ES|QL: Add FORK generative tests #129135
Merged
ES|QL: Add FORK generative tests #129135
+196
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioanatia
added
>non-issue
:Analytics/ES|QL
ioanatia
requested review from
ChrisHegarty,
afoucret,
tteofili and
fang-xing-esql
elasticsearchmachine
added
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
ChrisHegarty
approved these changes
Jun 9, 2025
|
|
||
| import static org.elasticsearch.xpack.esql.action.EsqlCapabilities.Cap.*; | ||
|
|
||
| public abstract class GenerativeForkRestTest extends EsqlSpecTestCase { |
There was a problem hiding this comment.
It might be obvious from the query, but maybe add a short description javadoc that summarises the intention.
|
|
||
| @Override | ||
| protected void doTest() throws Throwable { | ||
| String query = testCase.query + " | FORK (WHERE true) (WHERE true) | WHERE _fork == \"fork1\" | DROP _fork"; |
afoucret
approved these changes
Jun 10, 2025
20 tasks
mridula-s109
pushed a commit
to mridula-s109/elasticsearch
that referenced
this pull request
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tracked in #121950
This adds tests for FORK generated from the current CSV tests.
Tests that are using FORK/RRF already are skipped, since only a single FORK command is allowed for now per ES|QL query.
As a first stage, we just append
" | FORK (WHERE true) (WHERE true) | WHERE _fork == \"fork1\" | DROP _fork";to the test case query. This new query should produce the same results.By testing this I already uncovered a few things that were not working properly with FORK:
EsRelation(fixed in this PR)PropgateUnmappedFields( we should fix the typo in the name) does not handle n-ary plans that can multipleEsRelation- these tests we just skip because INSIST is still in snapshot and won't be released any time soon.While we can always add more tests specific for FORK, we will always play catch up with the other development that is happening in ES|QL. I also don't want think that for changes that seem unrelated to FORK, engineers need to add tests that are using FORK on each PR. However we need to catch any type of regression early in the process, which is why these types of generative tests that reuse the CSV tests we already have are a good middle ground.