Skip to content

[9.1] (backport #9757) chore: fix formatting issues in logp printf-style calls #9765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2025
Merged

[9.1] (backport #9757) chore: fix formatting issues in logp printf-style calls #9765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/ipc/listener_windows.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ func securityDescriptor(log *logger.Logger) (string, error) {
isAdmin, err := utils.HasRoot()
if err != nil {
// do not fail, agent would end up in a loop, continue with limited permissions
log.Warnf("failed to detect Administrator: %w", err)
log.Warnf("failed to detect Administrator: %v", err)
isAdmin = false // just in-case to ensure that in error case that its always false
}
// SYSTEM/Administrators can always talk over the pipe, even when not running as privileged
Expand All @@ -73,7 +73,7 @@ func securityDescriptor(log *logger.Logger) (string, error) {
gid, err := pathGID(paths.Top())
if err != nil {
// do not fail, agent would end up in a loop, continue with limited permissions
log.Warnf("failed to detect group: %w", err)
log.Warnf("failed to detect group: %v", err)
} else {
descriptor += "(A;;GA;;;" + gid + ")"
}
Expand Down
Loading