-
Notifications
You must be signed in to change notification settings - Fork 193
[otel] add receivers: apache, iis, mysql, postgresql v0.129.0 #9180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This pull request does not have a backport label. Could you fix it @mykola-elastic? 🙏
|
e6e7e67
to
55abc0b
Compare
It is very weird that unit tests failed on windows (ubuntu and macOS passed):
However, there is no problem with spanmetrics. It is used in the [metrics] pipeline as a receiver Update: seems the reason is that |
@mykola-elastic could you build the agent binary on this branch and compare it to main? We don't currently have tests for this, and I'd like to see what the impact of adding these dependencies is. Just running |
@swiatekm
|
66128e5
to
019b737
Compare
I initially added
|
Mykola does the CI pass without the IIS receiver addition ? |
@ishleenk17 it is still in progress but probably will pass, it needs another hour or so |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Id like to understand why we are adding SQLquery at this point |
Having the generic SQLQuery receiver similar to SQL input module will be beneficial if we have to build custom dashboards by giving the custom SQL queries irrespective of the database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving, assuming @strawgate can accept the inclusion of the sqlquery receiver
@ishleenk17 @strawgate removed sqlqueryreceiver |
d1b1a8e
to
020b766
Compare
020b766
to
45fa576
Compare
|
💚 Build Succeeded
History
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
@ishleenk17 I've create a different PR with merge conflicts resolved: #9344 |
Closing in favor of #9344 |
What does this PR do?
Receivers added:
Why is it important?
Needed in order to add OTEL content packs to elastic/integrations which use the data from the receivers listed
Checklist
I have commented my code, particularly in hard-to-understand areasI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature works./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues