Skip to content

ci: propagate e2e-testing errors #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
v1v merged 1 commit into from
Jul 27, 2022
Merged

ci: propagate e2e-testing errors #695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .ci/Jenkinsfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,7 +256,9 @@ pipeline {
elasticAgentVersion: "${env.BEAT_VERSION}-SNAPSHOT",
gitHubCheckName: "e2e-tests",
gitHubCheckRepo: env.REPO,
gitHubCheckSha1: env.GIT_BASE_COMMIT)
gitHubCheckSha1: env.GIT_BASE_COMMIT,
propagate: true,
wait: true)
Copy link
Member

@cmacknz cmacknz Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The agent isn't using the DRA process yet correct? So the flaky E2E tests won't prevent snapshot builds and build candidates from succeeding in the unified release process?

Copy link
Member Author

@v1v v1v Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The agent isn't using the DRA process yet correct?

That's correct

So the flaky E2E tests won't prevent snapshot builds and build candidates from succeeding in the unified release process?

The unified release process so far it does not depend on this pipeline, they just pick a particular commit and the build/package from it

Once the DRA is in place, then we might need to revisit this gate keeper

}
}
}
Expand Down