Skip to content

Do not propagate gateway errors. #2203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
michalpristas merged 3 commits into from
Feb 1, 2023
Merged

Do not propagate gateway errors. #2203

michalpristas merged 3 commits into from
Feb 1, 2023

Conversation

@michalpristas
Copy link
Contributor

@michalpristas michalpristas commented Jan 27, 2023

What does this PR do?

This PR removes reporting of errors to status reporter. We keep logs.

Why is it important?

This was agreed #1148
and implemented #1152 in V1.
Change got lost in migration to V2 architecture

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool

Fixes: #2194

@michalpristas michalpristas added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent Label for the Agent team backport-v8.6.0 Automated backport with mergify labels Jan 27, 2023
@michalpristas michalpristas requested a review from a team as a code owner January 27, 2023 09:24
@michalpristas michalpristas self-assigned this Jan 27, 2023
@michalpristas michalpristas requested review from AndersonQ and blakerouse and removed request for a team January 27, 2023 09:24
@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 27, 2023 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-01T14:18:32.115+0000

  • Duration: 16 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 4889
Skipped 13
Total 4902

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@elasticmachine
Copy link
Contributor

elasticmachine commented Jan 27, 2023 •
edited
Loading

🌐 Coverage report

Name Metrics % (covered/total) Diff
Packages 98.333% (59/60) 👍
Files 69.082% (143/207) 👍
Classes 68.514% (272/397) 👍
Methods 53.806% (834/1550) 👎 -0.03
Lines 39.19% (9092/23200) 👎 -0.05
Conditionals 100.0% (0/0) 💚

blakerouse
blakerouse approved these changes Jan 31, 2023
View reviewed changes
internal/pkg/agent/application/gateway/fleet/fleet_gateway_test.go Outdated
// ignore errors here
}
}
<-done
Copy link
Contributor

@blakerouse blakerouse Jan 31, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to stay here with all the removal that was done?

@michalpristas michalpristas merged commit 4107f0f into elastic:main Feb 1, 2023
@mergify mergify bot mentioned this pull request Feb 1, 2023
Merged
mergify bot pushed a commit that referenced this pull request Feb 1, 2023
@michalpristas @mergify
Do not propagate gateway errors. (#2203)
a772139 
Do not propagate gateway errors. (#2203)

(cherry picked from commit 4107f0f)
michalpristas added a commit that referenced this pull request Feb 1, 2023
@mergify @michalpristas
Do not propagate gateway errors. (#2203) (#2214)
08a62e3 
Do not propagate gateway errors. (#2203)

(cherry picked from commit 4107f0f)

Co-authored-by: Michal Pristas <[email protected]>
@blakerouse blakerouse mentioned this pull request Feb 6, 2023
Closed
michalpristas added a commit to michalpristas/elastic-agent that referenced this pull request Feb 7, 2023
@michalpristas
Revert "Do not propagate gateway errors. (elastic#2203)"
7562085 
This reverts commit 4107f0f.
michalpristas added a commit to michalpristas/elastic-agent that referenced this pull request Feb 8, 2023
@michalpristas
Revert "Do not propagate gateway errors. (elastic#2203)"
9a053f8 
This reverts commit 4107f0f.
michalpristas added a commit to michalpristas/elastic-agent that referenced this pull request Feb 8, 2023
@michalpristas
Revert "Do not propagate gateway errors. (elastic#2203)"
d21226b 
This reverts commit 4107f0f.
@michalpristas michalpristas mentioned this pull request Feb 8, 2023
Merged
6 tasks
@cmacknz cmacknz mentioned this pull request Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakerouse blakerouse blakerouse approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@michalpristas michalpristas

Labels

backport-v8.6.0 Automated backport with mergify bug Something isn't working Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Reset gateway error on successful request

3 participants

@michalpristas @elasticmachine @blakerouse