Skip to content

[8.4](backport #1371) Fix failures when using npipe monitoring endpoints #1372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalpristas merged 1 commit into from
Sep 29, 2022
Merged

[8.4](backport #1371) Fix failures when using npipe monitoring endpoints #1372

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions internal/pkg/core/monitoring/beats/sidecar_monitor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,10 @@ func (b *SidecarMonitor) EnrichArgs(spec program.Spec, pipelineID string, args [
func (b *SidecarMonitor) Cleanup(spec program.Spec, pipelineID string) error {
endpoint := MonitoringEndpoint(spec, b.operatingSystem, pipelineID, true)
drop := monitoringDrop(endpoint)
if drop == "" {
// not exposed using sockets
return nil
}

return os.RemoveAll(drop)
}
Expand All @@ -104,6 +108,11 @@ func (b *SidecarMonitor) Prepare(spec program.Spec, pipelineID string, uid, gid
endpoint := MonitoringEndpoint(spec, b.operatingSystem, pipelineID, true)
drop := monitoringDrop(endpoint)

if drop == "" {
// not exposed using sockets
return nil
}

if err := os.MkdirAll(drop, 0775); err != nil {
return errors.New(err, fmt.Sprintf("failed to create a directory %q", drop))
}
Expand Down