Skip to content

Use at least warning level for all status logs #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joshdover merged 3 commits into from
Sep 19, 2022
Merged

Use at least warning level for all status logs #1218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bd2a88e
Use at least warning level for all status logs
joshdover Sep 15, 2022
bebe50e
Changelog
joshdover Sep 15, 2022
b547f85
Merge branch 'main' into status-warn
joshdover Sep 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.next.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,6 +114,7 @@
- Agent updates will clean up unneeded artifacts. {issue}693[693] {issue}694[694] {pull}752[752]
- Use the Elastic Agent configuration directory as the root of the `inputs.d` folder. {issues}663[663]
- Fix a panic caused by a race condition when installing the Elastic Agent. {issues}806[806]
- Use at least warning level for all status logs {pull}1218[1218]
- Remove fleet event reporter and events from checkin body. {issue}993[993]

==== New features
Expand Down
7 changes: 3 additions & 4 deletions internal/pkg/core/status/reporter.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,10 +250,9 @@ func (r *controller) updateStatus() {
}

func (r *controller) logStatus(status AgentStatusCode, message string) {
logFn := r.log.Infof
if status == Degraded {
logFn = r.log.Warnf
} else if status == Failed {
// Use at least warning level log for all statuses to make sure they are visible in the logs
logFn := r.log.Warnf
if status == Failed {
logFn = r.log.Errorf
}

Expand Down