Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 26, 2025

What does this PR do?

This PR restores the check for the ms_tls13kdf Go build tag on the packaged FIPS-capable elastic-agent binary and component binaries. However, it only checks for this build tag if the binary was built with Go 1.24.x, which is where this tag was supported and required to ensure FIPS compliance.

Why is it important?

To ensure FIPS compliance of binaries built with Go 1.24.x.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

None; this is a change to a Go test that gets executed when Elastic Agent is packaged.

How to test this PR locally

Create a FIPS-capable Elastic Agent package. Make sure a Go version other than 1.24.x is being used.

cat .go-version
FIPS=true SNAPSHOT=true EXTERNAL=true PLATFORMS="linux/arm64" PACKAGES="tar.gz" mage -v package

Make sure the package builds without any errors.


This is an automatic backport of pull request #10160 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner September 26, 2025 09:22
@mergify mergify bot added the backport label Sep 26, 2025
@mergify mergify bot requested review from blakerouse and straistaru and removed request for a team September 26, 2025 09:22
@github-actions github-actions bot added Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog labels Sep 26, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@ycombinator ycombinator enabled auto-merge (squash) September 26, 2025 10:18
@ycombinator ycombinator merged commit 706aa03 into 8.19 Sep 26, 2025
19 checks passed
@ycombinator ycombinator deleted the mergify/bp/8.19/pr-10160 branch September 26, 2025 12:20
Copy link

@elasticmachine
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

cc @ycombinator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants